418565 - "ASSERTION: Inner window detected in Equality hook!" at Gmail

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect, P1)

Description

[Jesse Ruderman]

Loading https://mail.google.com/mail/ (I'm logged in) gives me a bunch of:

###!!! ASSERTION: Inner window detected in Equality hook!: 'other->IsOuterWindow()', file /Users/jruderman/trunk/mozilla/dom/src/base/nsDOMClassInfo.cpp, line 6268

I get a bunch more when I close the window, too.

Initially security-sensitive because bug 394012 is security-sensitive and full of private comments.

Comment 2

[Andrew Schultz]

Attachment: testcase

reduced from http://www.howtoforge.com/jquery/jquery-latest.pack.js

if (window==this) {}

Comment 4

[Bob Clary [:bc] (inactive)]

I can reproduce assertion with test in comment 2. This is the second most common assertion on linux on the top sites.

Comment 5

[Blake Kaplan (:mrbkap) (inactive)]

Attachment: Proposed fix

We're computing |this| here, so we need to outerize.

Comment 6

[Blake Kaplan (:mrbkap) (inactive)]

Guessing at the TM.

Comment 7

[Blake Kaplan (:mrbkap) (inactive)]

Note to drivers: this should block as this patch fixes the important part of bug 420480.

Comment 8

[Mike Beltzner [:beltzner, not reading bugmail]]

Does this need to block beta 4?

Comment 9

[Mike Beltzner [:beltzner, not reading bugmail]]

Apparently it does! a1.9b4=beltzner once we have a reviewed patch.

Comment 10

[Brendan Eich [:brendan]]

Comment on attachment 306939 [details] [diff] [review]
Proposed fix

beltzner telegraphed this too.

/be

Comment 11

[Brendan Eich [:brendan]]

Fixed:

js/src/jsinterp.c 3.459

/be

Comment 12

[Jesse Ruderman]

Should I check in Andrew's testcase as a crashtest once beta 4 ships?  Or can this be tested using a pure-JS-engine testcase?

Comment 13

[Bob Clary [:bc] (inactive)]

I can't do ASSERTION unless its fatal. Are the crashtests run with fatal assertions?

Comment 14

[Jeff Walden [:Waldo]]

Not yet, sadly; it requires tinderboxen with fatal assertions, which requires debug tinderboxen, which requires a ton of effort to get them up to snuff enough to be able to run everything without failing.  (There's at least one on MozillaTest which isn't doing so well and needs developer and probably admin love both.)  For now we just commit and plan to deal with asserts when we have the ability to do so on tinderboxen.  :-\