418599 - Radio and checkbox outlines are too wide

Status: RESOLVED WORKSFORME

(Toolkit :: UI Widgets, defect)

Description

[Rod Whiteley]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8.1.12) Gecko/20080201 Firefox/2.0.0.12
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9b4pre) Gecko/2008021904 Minefield/3.0b4pre

The dotted border or outline that indicates focus on a checkbox or radio button extends to the container padding (flex="1") instead of only around the label.  This makes Mozilla applications look subtly weird.

Reproducible: Always

Steps to Reproduce:
1. In Minefield choose Tools - Options - Main
2. Move focus to the checkbox.
3. Move focus to the radio group and select the second radio button.
Actual Results:  
Both the checkbox outline and the radio button outline extend far beyond their labels.

Expected Results:  
4. Choose File - Print... (a system dialog) Compare the Print to file checkbox and the All radio button.  Notice that in each case the outline matches the width of the label, but the mouseover region extends right to the container padding.

In Firefox 2, this bug only affects checkboxes.  Radio buttons are OK.  In Minefield, it affects both checkboxes and radio buttons.

Beware of fixing this in a way that breaks the mouseover region.  The common workaround is for user interface code to place an extra hbox around every checkbox, but this makes the mouseover region wrong.

Comment 1

[Ria Klaassen (not reading all bugmail)]

Confirmed with Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9b4pre) Gecko/2008022008 Minefield/3.0b4pre

Comment 2

[Ria Klaassen (not reading all bugmail)]

Regression window is
http://bonsai.mozilla.org/cvsquery.cgi?module=PhoenixTinderbox&date=explicit&mindate=1171292280&maxdate=1171298759
with only one bug in it: bug 370109

Comment 3

[[e-mail]]

Actually the label itself extends to that width too; I don't know why but the label needs to be flexible otherwise it won't wrap in the multiline case.

Comment 4

[Michelle Funches - QA]

Tested in Release - outline for radio and check-boxes is accurately fitted to outline the option
Version 	46.0.1
Build ID 	20160502172042
User Agent 	Mozilla/5.0 (Windows NT 5.1; rv:46.0) Gecko/20100101 Firefox/46.0

Comment 5

[Michelle Funches - QA]

Attachment: RadioAndCheckbox.html