Closed
Bug 418614
Opened 18 years ago
Closed 18 years ago
js1_5/Regress/regress-249211.js no longer completes in browser debug build
Categories
(Core :: JavaScript Engine, defect)
Tracking
()
VERIFIED
FIXED
People
(Reporter: bc, Assigned: igor)
References
()
Details
(Keywords: regression, testcase)
Attachments
(1 file, 2 obsolete files)
|
1.63 KB,
patch
|
mrbkap
:
review+
brendan
:
approval1.9+
|
Details | Diff | Splinter Review |
In opt browser builds, the test will print:
BUGNUMBER: 249211
STATUS: support export and import for 4xp
PASSED! support export and import for 4xp
however, in browser debug builds the PASSED line is never output. Reproduced locally with linux and on the test farm with windows. Mac does not appear affected. It appears to have regressed in the last 24 hours.
Flags: in-testsuite+
Flags: in-litmus-
Flags: blocking1.9?
|
Reporter | |
Comment 1•18 years ago
|
||
ditto js1_5/Regress/regress-354924.js
|
Assignee | |
Comment 2•18 years ago
|
||
I should learn to like OK.
Attachment #304519 -
Flags: review?(mrbkap)
|
||
Comment 3•18 years ago
|
||
Comment on attachment 304519 [details] [diff] [review]
v1
>+ if (ok)
> goto error;
Er, don't you mean |if (!ok)|?
|
|
Assignee | |
Comment 4•18 years ago
|
||
Fixing the issue from the previous comment.
Attachment #304519 -
Attachment is obsolete: true
Attachment #304525 -
Flags: review?(mrbkap)
Attachment #304519 -
Flags: review?(mrbkap)
|
|
||
Updated•18 years ago
|
Attachment #304525 -
Flags: review?(mrbkap) → review+
|
|
Assignee | |
Comment 5•18 years ago
|
||
The new patch uses a better assert: ok is true if and only if we have looped through the whole array.
Attachment #304525 -
Attachment is obsolete: true
Attachment #304526 -
Flags: review?(mrbkap)
|
|
||
Updated•18 years ago
|
Attachment #304526 -
Flags: review?(mrbkap) → review+
|
|
Assignee | |
Comment 6•18 years ago
|
||
Comment on attachment 304526 [details] [diff] [review]
v3
The patch fixes a regression, a read of released memory.
Attachment #304526 -
Flags: approval1.9?
|
|
||
Comment 7•18 years ago
|
||
Comment on attachment 304526 [details] [diff] [review]
v3
Sorry, I'm dense (I clearly failed at code review here) -- what was the bug? Approving anyway, and off to get more coffee (late night).
/be
Attachment #304526 -
Flags: approval1.9? → approval1.9+
|
|
||
Comment 8•18 years ago
|
||
The bug was:
JS_DestroyIdArray(cx, ida);
- if (i != ida->length)
since JS_DestroyIdArray = JS_free.
|
|
Assignee | |
Comment 9•18 years ago
|
||
I checked in the patch from comment 5 to the trunk:
http://bonsai.mozilla.org/cvsquery.cgi?module=PhoenixTinderbox&branch=HEAD&cvsroot=%2Fcvsroot&date=explicit&mindate=1203539583&maxdate=1203539761&who=igor%25mir2.org
Status: NEW → RESOLVED
Closed: 18 years ago
Resolution: --- → FIXED
|
|
||
Comment 10•18 years ago
|
||
(In reply to comment #8)
> The bug was:
> JS_DestroyIdArray(cx, ida);
> - if (i != ida->length)
>
> since JS_DestroyIdArray = JS_free.
Too funny -- I saw that as the caffeine hit ;-).
/be
|
|
Reporter | |
Updated•10 years ago
|
Flags: blocking1.9?
You need to log in
before you can comment on or make changes to this bug.
Description
•