418640 - Tests running doesn't start because of an error in runtests.py.

Status: VERIFIED FIXED

(Tamarin Graveyard :: Build Config, defect)

Description

[Evgeniy Andrievskiy]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8.1.12) Gecko/20080201 Firefox/2.0.0.12
Build Identifier: 

Tests running doesn't start because of an error in runtests.py:

cputype={'i386':'x86','i686':'x86','Power Macintosh':'ppc'}[platform.machine()]

the reason - platform.machine() returns blank string.

Reproducible: Always

Steps to Reproduce:
1. set all required environment variables
2. run tamarin-central\test\acceptance\runtests.py
Actual Results:  
error, python exits.


error occurs when using python 2.5.1 and 2.4.3

Comment 1

[Chris Peyer]

The testsuite must be run using cygwin on windows machines.

Comment 2

[Steven Johnson]

Would be useful to not have to require cygwin; Mozilla now uses MSYS instead of cygwin for builds IIRC. Could it be fixed with simple changes?

Comment 3

[Brent Baker]

Probably a safe bet would be to default to x86. If for somebody this is incorrect they can get around the issue by just specifying the --config switch when running the script. That is why this is here, it is called in instances where the config is not passed in and it attempts to generate the configuration name (which is then used for looking for expected failures).

Comment 4

[Jason Orendorff [:jorendorff]]

Attachment: v1 - default to x86 (and warn)

This patch makes 'x86' the default on Python implementations where platform.machine() returns an empty string.

It also changes the indentation around there from spaces to tabs, to match the rest of the file.

Comment 6

[Jason Orendorff [:jorendorff]]

Comment on attachment 322771 [details] [diff] [review]
v1 - default to x86 (and warn)

Retracting review, since Dan's patch in bug 418640 does a little more work than mine.

Comment 7

[Jason Orendorff [:jorendorff]]

Oops, I meant Dan's patch in bug 436098.

Comment 8

[Dan Schaffer]

talked to Brent and we modified the patch:
1.  if --config is passed to runtests do not have to call platform.system() and platform.machine() workaround for different platform
2.  workaround activestate if cputype is '' default to windows
3.  if platform.system() or platform.machine() fails or returns unmapped value print error message explaining how to use --config, this is better than KeyError 

Comment 9

[Dan Schaffer]

Attachment: patch

Comment 10

[Dan Schaffer]

Attachment: runtests patch for tamarin-tracing

Comment 11

[Brent Baker]

Comment on attachment 322819 [details] [diff] [review]
runtests patch for tamarin-tracing

Is it possible to display a warning to the user when the script is unable to determine the CPU and it defaults to x86?

Comment 12

[Dan Schaffer]

triaging old bugs.  this has been fixed.