Created attachment 304515 [details] [diff] [review] patch v.1 ERROR is defined when building on windows mobile. This cases a build busted when building layout/inspector because inISearchObserver.idl redefines ERROR. Patch prefixes these constants with
Attachment #304515 - Flags: review?(dbaron)
Comment on attachment 304515 [details] [diff] [review] patch v.1 r=dbaron Does Firebug or something depend on this? We don't actually seem to use it in our own codebase.
Attachment #304515 - Flags: review?(dbaron) → review+
i didn't find anything in our tree and searching around on google didn't find consumers (just copies of the inISearchObserver idl). Do you think we should also change the UUID?
dbaron said no to my question on IRC.
Comment on attachment 304515 [details] [diff] [review] patch v.1 a=beltzner for 1.9
Attachment #304515 - Flags: approval1.9? → approval1.9+
Checking in layout/inspector/public/inISearchObserver.idl; /cvsroot/mozilla/layout/inspector/public/inISearchObserver.idl,v <-- inISearchObserver.idl new revision: 1.8; previous revision: 1.7 done Checking in layout/inspector/src/inCSSValueSearch.cpp; /cvsroot/mozilla/layout/inspector/src/inCSSValueSearch.cpp,v <-- inCSSValueSearch.cpp new revision: 1.27; previous revision: 1.26 done
Status: ASSIGNED → RESOLVED
Last Resolved: 10 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.