Closed Bug 418654 Opened 15 years ago Closed 15 years ago

windows widget honor NS_PRINTING

Categories

(Firefox Build System :: General, defect)

Product:
Firefox Build System
Component:
General
Platform:
All
Windows Mobile 6 Standard
Type:
defect
Priority:
Not set
Severity:
blocker

Tracking

(Not tracked)

Status:
RESOLVED FIXED

People

(Reporter: dougt, Assigned: dougt)

Details

Attachments

(1 file)

patch v.1
2.14 KB, patch
emaijala+moz
: review+
beltzner
: approval1.9+
Details | Diff | Splinter Review 
on windows mobile, we aren't printing.  We would like to not compile the files related to printing.
Attached patch patch v.1 — — Splinter Review 

        Attachment #304523 -
        Flags: review?(emaijala)

    
    

    
  
Comment on attachment 304523 [details] [diff] [review]
patch v.1

r=me provided you fix this:

+ifdef NS_PRINTING
+CPPSRCS		= \

I believe that should be +=

        Attachment #304523 -
        Flags: review?(emaijala) → review+

    
    

    
  
Comment on attachment 304523 [details] [diff] [review]
patch v.1

good catch!

        Attachment #304523 -
        Flags: approval1.9?

    
    

    
  
Comment on attachment 304523 [details] [diff] [review]
patch v.1

a=beltzner for 1.9

        Attachment #304523 -
        Flags: approval1.9? → approval1.9+

    
    

    
  
Checking in widget/src/build/nsWinWidgetFactory.cpp;
/cvsroot/mozilla/widget/src/build/nsWinWidgetFactory.cpp,v  <--  nsWinWidgetFactory.cpp
new revision: 1.77; previous revision: 1.76
done
Checking in widget/src/windows/Makefile.in;
/cvsroot/mozilla/widget/src/windows/Makefile.in,v  <--  Makefile.in
new revision: 3.51; previous revision: 3.50
done

Status: ASSIGNED → RESOLVED
Closed: 15 years ago
Resolution: --- → FIXED

    
  
Product: Core → Firefox Build System

          You need to log in
          before you can comment on or make changes to this bug.