Closed Bug 418682 Opened 13 years ago Closed 13 years ago

Teach compare-locales to ignore gecko.handlerService.defaultHandlersVersion and gecko.handlerService.schemes.*

Categories

(Firefox Build System :: General, defect)

defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED
mozilla1.9beta4

People

(Reporter: Gavin, Assigned: Gavin)

Details

Attachments

(2 files)

Bug 395277 added optional prefs to region.properties, similar to browser.contentHandlers.* and browser.search.order*. Need to fix compare-locales so that it doesn't fail if these are omitted.
Attached patch extend the hackSplinter Review
Assignee: nobody → gavin.sharp
Status: NEW → ASSIGNED
Attachment #304560 - Flags: review?(benjamin)
Comment on attachment 304560 [details] [diff] [review]
extend the hack

I thought there was some way (in a comment perhaps?) to annotate these in the .properties file itself, but this is ok while Axel is on vacation.
Attachment #304560 - Flags: review?(benjamin) → review+
mozilla/toolkit/locales/compare-locales.pl 	1.11
Status: ASSIGNED → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla1.9beta4
Need to fix the new scripts, too.
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Attached patch patchSplinter Review
Attachment #307009 - Flags: review?(l10n)
Comment on attachment 307009 [details] [diff] [review]
patch

r=me for now.

I'm not sure that we really want to allow *none* handlers, but that's subject of a different bug, and affects both the web and protocol handlers alike.
Attachment #307009 - Flags: review?(l10n) → review+
mozilla/browser/locales/filter.py 	1.2 
Status: REOPENED → RESOLVED
Closed: 13 years ago13 years ago
Resolution: --- → FIXED
Product: Core → Firefox Build System
You need to log in before you can comment on or make changes to this bug.