Teach compare-locales to ignore gecko.handlerService.defaultHandlersVersion and gecko.handlerService.schemes.*

RESOLVED FIXED in mozilla1.9beta4

Status

RESOLVED FIXED
11 years ago
a year ago

People

(Reporter: Gavin, Assigned: Gavin)

Tracking

Trunk
mozilla1.9beta4

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(2 attachments)

Bug 395277 added optional prefs to region.properties, similar to browser.contentHandlers.* and browser.search.order*. Need to fix compare-locales so that it doesn't fail if these are omitted.
Assignee: nobody → gavin.sharp
Status: NEW → ASSIGNED
Attachment #304560 - Flags: review?(benjamin)

Comment 2

11 years ago
Comment on attachment 304560 [details] [diff] [review]
extend the hack

I thought there was some way (in a comment perhaps?) to annotate these in the .properties file itself, but this is ok while Axel is on vacation.
Attachment #304560 - Flags: review?(benjamin) → review+
mozilla/toolkit/locales/compare-locales.pl 	1.11
Status: ASSIGNED → RESOLVED
Last Resolved: 11 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla1.9beta4
Need to fix the new scripts, too.
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Posted patch patchSplinter Review
Attachment #307009 - Flags: review?(l10n)

Comment 6

11 years ago
Comment on attachment 307009 [details] [diff] [review]
patch

r=me for now.

I'm not sure that we really want to allow *none* handlers, but that's subject of a different bug, and affects both the web and protocol handlers alike.
Attachment #307009 - Flags: review?(l10n) → review+
mozilla/browser/locales/filter.py 	1.2 
Status: REOPENED → RESOLVED
Last Resolved: 11 years ago11 years ago
Resolution: --- → FIXED

Updated

a year ago
Product: Core → Firefox Build System
You need to log in before you can comment on or make changes to this bug.