418699 - Session restore with multiple http auth prompts fails to load pages

Status: VERIFIED FIXED

(Core :: Widget: Cocoa, defect, P1)

Description

[Nick Thomas [:nthomas] (UTC+12)]

Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.4; en-US; rv:1.9b4pre) Gecko/2008022004 Minefield/3.0b4pre

Discovered with today's mac nightly.

STR:
1, New profile
2, Replace default tabset with
     http://people.mozilla.org/~nthomas/test/foo
     http://people.mozilla.org/~nthomas/test/bar
     http://www.google.com (any non-auth page ought to do)
   Cancel each auth prompt (or enter test/moose, doesn't seem to matter)
3, Set Minefield to "Show windows and tabs from last time"
4, Restart Minefield
5, Cancel first auth prompt

Expected results: second auth prompt, first tab to say "Authorization denied"

Actual results: both tabs requiring auth have title "Loading...", don't finish that, and are unresponsive to changing url etc.

You can enter the auth at step 5 and get the same result. 
It only happens if you have multiple tabs requiring auth, one works fine.

This is a regression between the Mac hourly builds of 2008-02-19 17:24 and 18:36.  The checkins in that are 
  http://bonsai.mozilla.org/cvsquery.cgi?module=PhoenixTinderbox&date=explicit&mindate=1203470640&maxdate=1203474959

I can't reproduce on Linux, so I'm guessing it's bug 417124.

Comment 1

[Håkan Waara]

Are the auth prompts sheets? Some logic was changed related to how nested sheets work...

Comment 2

[Nick Thomas [:nthomas] (UTC+12)]

Yes, they slide out from the window's titlebar.

Comment 3

[Josh Aas]

Patch coming up, I know what the problem is. This is an issue with sibling sheets, not nested sheets. The second sheet's show code basically never runs because of the way we track visibility for siblings.

Comment 4

[Josh Aas]

Attachment: fix v1.0

Comment 5

[Ben Turner (not reading bugmail, use the needinfo flag!)]

Comment on attachment 304660 [details] [diff] [review]
fix v1.0

This looks good to me.

Comment 6

[Josh Aas]

landed on trunk