js shell should report warnings by default

RESOLVED FIXED in Future

Status

()

Core
JavaScript Engine
P3
normal
RESOLVED FIXED
18 years ago
17 years ago

People

(Reporter: brendan, Assigned: Mike McCabe)

Tracking

Trunk
Future
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Reporter)

Description

18 years ago
It needs the -w option to do so, currently.  The lack of warnings has hurt us
already, in getting the testsuite back on its feet.

I say we should just fix this fast, not in absolute nsbeta2/3 priority order.
But I'm not sure the PDT will agree -- I'm currently arguing with phil about how
trivial fixes should not be starved by high priority, less easily fixed bugs. 
Obviously, not all small fixes are trivial, and too many truly trivial fixes can
starve out higher priority bugs, but I think the PDT is erring on the other
side, at the moment.

/be

Updated

18 years ago
Status: NEW → ASSIGNED
(Assignee)

Comment 1

18 years ago
[SPAM] Marking milestone 'future' as part of nsbeta3 triage.
Target Milestone: --- → Future
(Assignee)

Comment 2

18 years ago
What's the right new flag for 'suppress warnings?'  I'm leaning towards -W.  -nw
wouldn't be consistent; other args are single-char.  Could do --no-warnings, by
itself or in addition.
(Assignee)

Comment 3

18 years ago
Created attachment 15844 [details] [diff] [review]
Make warnings default; suppress with -W.
(Reporter)

Comment 4

18 years ago
-W is ok with me, but maybe we should use getopt_long on Linux etc.?

/be
(Assignee)

Comment 5

18 years ago
Fix checked in.  Leaving getopt_long for another round of js.c changes.

I left the -w option intact, in case somebody was using it.
Status: ASSIGNED → RESOLVED
Last Resolved: 18 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.