418748 - Preferences Window under Mac needs fixing

Status: RESOLVED FIXED

(Other Applications Graveyard :: ChatZilla, defect)

Description

[David Corry]

User-Agent:       Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.5; en-US; rv:1.9b4pre) Gecko/2008021904 Minefield/3.0b4pre
Build Identifier: 

For whatever reason — probably the default Mac css? — the preferences window has a variety of issues:

1. Opens up too small - the size of the tabs causes the tab box to overflow.
2. The header on top is teeny, so any text inside of it isn't shown.
3. Some odd spacing underneath the tab box

I don't know if this is still related, but the tooltips are really squished under Firefox 3/XULRunner.

Reproducible: Always

Steps to Reproduce:
1. Open Preferences
Actual Results:  
Cosmetic errors

Expected Results:  
Better appearance

Comment 1

[David Corry]

Attachment: preference window, once opened

Comment 2

[Mitchell Field [:Mitch]]

Attachment: Patch v1.0

This patch is a subset of my patches submitted for bug 410377. Similar issues are present on both Songbird and all Mac applications capable of supporting ChatZilla (to my knowledge). Thanks to David Corry for finding an appropriate preferences dialog width value.

Comment 3

[:Gijs (he/him)]

Comment on attachment 304678 [details] [diff] [review]
Patch v1.0

>Index: xul/content/config.css
>===================================================================
>+/* Make the weird, blue dot disappear on Songbird, Mac. */

Nit: make that say "Songbird and Mac"

>+/* Make the preference category header not disappear on Songbird, Mac. */

Nit: same.


r=me


David, what exactly do you mean by 'weird spacing'? The tabs look OK to me, but perhaps that's just my ignorance... :-)

Comment 4

[Mitchell Field [:Mitch]]

Attachment: Patch v1.1

Comment 5

[James Ross]

I don't like that patch.

Comment 6

[:Gijs (he/him)]

Comment on attachment 304693 [details] [diff] [review]
Patch v1.1

Alright, let's hear why! :-)

Comment 7

[James Ross]

Comment on attachment 304693 [details] [diff] [review]
Patch v1.1

The window is already wide, the last thing I was is it any wider. If Mac's crappy theme doesn't like it, make it wider on Mac only (and give a picture). The same goes for the pref-header, really - it works fine on other platforms, so work out why it doesn't on Mac and either fix the platform or make it clear why you're hacking the thing to pieces. And give a picture on ALL platforms after such a hack.

Comment 8

[Loïck Magnin]

Another cosmetic detail: when clicking on the blue button on the top right corner, the "tabs" disappear as expected, but the window should be resized. (The height of the content of the window should be a constant)

Comment 9

[:Gijs (he/him)]

(In reply to comment #8)
> Another cosmetic detail: when clicking on the blue button on the top right
> corner, the "tabs" disappear as expected, but the window should be resized.
> (The height of the content of the window should be a constant)

Mozilla does that button stuff. I don't think we can even get an event as to when it happens. Also, I can't reproduce. Finally, it should have its own bug.

Comment 10

[:Gijs (he/him)]

Attachment: Patch

I would have sworn I already did a patch for this, in this way. Anyway, here it is. I checked the sizes carefully, and will attach a before/after picture.


As for the stupid header, for me, it's just completely disappeared. I worked out that somewhere in pinstripe it gets rid of this, for "platform parity", so that's not getting changed in a hurry. I don't know if we should, I don't think the header is terribly important - but then the tabs should probably move up. Opinions on that?

Comment 11

[:Gijs (he/him)]

Attachment: Before

Comment 12

[:Gijs (he/him)]

Attachment: After

Comment 13

[James Ross]

(In reply to comment #10)
> but then the tabs should probably move up.

Sounds like they're using the wrong CSS to hide it (i.e. not display: none), if you ask me. Can you attack with DOM Inspector and see if it's just invisible or what?

Comment 14

[:Gijs (he/him)]

(In reply to comment #13)
> (In reply to comment #10)
> > but then the tabs should probably move up.
> 
> Sounds like they're using the wrong CSS to hide it (i.e. not display: none), if
> you ask me. Can you attack with DOM Inspector and see if it's just invisible or
> what?

.dialogheader-title is display: none (the title label), but the dialogheader itself still has a bunch of padding and margin, which I guess would account for the whatever-odd number of pixels that are magically blank. Maybe we should just remove the header altogether on mac, if that is "platform parity" ? :-(

Comment 15

[James Ross]

Comment on attachment 358198 [details] [diff] [review]
Patch

Holy hacks, Batman! Can you put an XXX on that comment, this is like the worst possible way to resize the window, but I'll take it for now.

Get rid of that extra blank line, too.

Comment 16

[:Gijs (he/him)]

Checking in mozilla/extensions/irc/xul/content/config.js;
/cvsroot/mozilla/extensions/irc/xul/content/config.js,v  <--  config.js
new revision: 1.19; previous revision: 1.18
done