418765 - rest params cause compiler error

Status: RESOLVED FIXED

(Tamarin Graveyard :: Self-hosting compiler (ESC), defect)

Description

[Mark Hammond [:markh] [:mhammond]]

The following code:
"""
{
    public class bar	{
        public function bang(...s) {;}
    }
}
"""
causes:
ReferenceError: Error #1065: Variable restParameter is not defined.
        at Parse::Parser/Parse::nonemptyParameters()[../src/parse.es:4498]
        at Parse::Parser/Parse::parameters()[../src/parse.es:4474]
        at Parse::Parser/Parse::functionSignature()[../src/parse.es:4381]
        at Parse::Parser/Parse::functionDefinition()[../src/parse.es:4044]
        at Parse::Parser/Parse::annotatableDirective()[../src/parse.es:5076]
        at Parse::Parser/Parse::directive()[../src/parse.es:4996]
...

A quick grep shows restParameter isn't defined anywhere.

Comment 1

[Lars T Hansen]

Attachment: Patch

This isn't squeaky-clean but it's roughly right.

Comment 2

[Mark Hammond [:markh] [:mhammond]]

Comment on attachment 304814 [details] [diff] [review]
Patch

looks good and wfm - thx.

Comment 3

[Lars T Hansen]

Pushed.