418792 - l10n specific preferences not working (en-US instead of de in user agent string in localized builds)

Status: RESOLVED FIXED

(Calendar :: Build Config, defect)

Description

[Thorsten 'nightrat' Fritz]

Attachment: screenshot

Click "About Calendar" in localized builds (1.8 branch tested) shows the user agent string that contains en-US instead of de oder da(tested as well).

Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8.1.13pre) Gecko/20080219 Calendar/0.8pre

If this is the wrong componet, please change it to the right one.

Comment 1

[Stefan Sitter [:ssitter]]

Confirmed.

I think the problem is that the file sunbird-l10n.js is shipped in the wrong folder and therefore has no affect:

Currently: sunbird\defaults\preferences\sunbird-l10n.js

Should be: sunbird\defaults\pref\sunbird-l10n.js

This mean offer locale specific preferences like Week start are not working.

Comment 2

[Stefan Sitter [:ssitter]]

http://lxr.mozilla.org/mozilla1.8/source/calendar/locales/Makefile.in#88

 88 libs-%:
 89         @$(MAKE) -C ../../toolkit/locales libs-$*
 90         @$(MAKE) -C ../sunbird/locales libs AB_CD=$* XPI_NAME=locale-$*
 91         @$(MAKE) libs AB_CD=$* XPI_NAME=locale-$* PREF_DIR=defaults/pref

The line (90) added for Bug 413868 needs the PREF_DIR argument too I guess.

Comment 3

[Stefan Sitter [:ssitter]]

Attachment: proposed fix

Comment 4

[ause]

Comment on attachment 304699 [details] [diff] [review]
proposed fix

moves sunbird-l10n.js to correct location

Comment 5

[ause]

committed to branch and trunk

Comment 6

[Michael Wolf]

Doesn't work in Sunbird 0.8 Release. I have to change general.useragent.locale to my locale (hsb="Upper Sorbian") manually, then it works.

Comment 7

[Stefan Sitter [:ssitter]]

(In reply to comment #6)
Maybe your are not using a localized build but an en-US build with language pack installed.

Comment 8

[Michael Wolf]

(In reply to comment #7)
> (In reply to comment #6)
> Maybe your are not using a localized build but an en-US build with language
> pack installed.
> 
I'm preparing a zip version. But I think Sunbird (and the same issue is for Fx and TB) should take the general.useragent.locale from /global/intl.properties. What else this information in /global/intl.properties is for?