418796 - Cleanup imgContainer and decom GetCurrentFrameNoRef

Status: VERIFIED FIXED

(Core :: Graphics: ImageLib, defect)

Description

[Alfred Kayser]

Attachment: V1: Do some code cleanup

Two types of cleanup for imgContainer:
* Use NS_ENSURE_ macro's where possible to make error reporting and debugging consistent and easier.
* decom GetCurrentFrameNoRef, returning frame when successful, or null otherwise

This makes this code easier to maintain (as there is more work needed on the imgContainer).

Comment 1

[Stuart Parmenter]

Comment on attachment 304692 [details] [diff] [review]
V1: Do some code cleanup

this looks fine

Comment 2

[Mike Beltzner [:beltzner, not reading bugmail]]

Comment on attachment 304692 [details] [diff] [review]
V1: Do some code cleanup

a1.9=beltzner

Comment 3

[Reed Loden [:reed]]

Checking in modules/libpr0n/src/imgContainer.cpp;
/cvsroot/mozilla/modules/libpr0n/src/imgContainer.cpp,v  <--  imgContainer.cpp
new revision: 1.68; previous revision: 1.67
done
Checking in modules/libpr0n/src/imgContainer.h;
/cvsroot/mozilla/modules/libpr0n/src/imgContainer.h,v  <--  imgContainer.h
new revision: 1.31; previous revision: 1.30
done

Comment 4

[Alfred Kayser]

Thanks!