Closed Bug 418796 Opened 15 years ago Closed 15 years ago

Cleanup imgContainer and decom GetCurrentFrameNoRef

Categories

(Core :: Graphics: ImageLib, defect)

Product:
Core
Component:
Graphics: ImageLib
Type:
defect
Priority:
Not set
Severity:
minor

Tracking

()

Status:
VERIFIED FIXED
Milestone:
mozilla1.9beta5

People

(Reporter: alfredkayser, Assigned: alfredkayser)

Details

(Keywords: memory-footprint)

Attachments

(1 file)

V1: Do some code cleanup
13.71 KB, patch
pavlov
: review+
beltzner
: approval1.9+
Details | Diff | Splinter Review 
Two types of cleanup for imgContainer:
* Use NS_ENSURE_ macro's where possible to make error reporting and debugging consistent and easier.
* decom GetCurrentFrameNoRef, returning frame when successful, or null otherwise

This makes this code easier to maintain (as there is more work needed on the imgContainer).
Attachment #304692 - Flags: review?(pavlov)
Version: unspecified → Trunk
Comment on attachment 304692 [details] [diff] [review]
V1: Do some code cleanup

this looks fine
Attachment #304692 - Flags: review?(pavlov) → review+
Attachment #304692 - Flags: approval1.9?
Flags: wanted1.9.0.x?
Comment on attachment 304692 [details] [diff] [review]
V1: Do some code cleanup

a1.9=beltzner
Attachment #304692 - Flags: approval1.9? → approval1.9+
Keywords: checkin-needed
Checking in modules/libpr0n/src/imgContainer.cpp;
/cvsroot/mozilla/modules/libpr0n/src/imgContainer.cpp,v  <--  imgContainer.cpp
new revision: 1.68; previous revision: 1.67
done
Checking in modules/libpr0n/src/imgContainer.h;
/cvsroot/mozilla/modules/libpr0n/src/imgContainer.h,v  <--  imgContainer.h
new revision: 1.31; previous revision: 1.30
done
Status: NEW → RESOLVED
Closed: 15 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → mozilla1.9beta5
Thanks!
Status: RESOLVED → VERIFIED
Flags: wanted1.9.0.x?
You need to log in before you can comment on or make changes to this bug.