418813 - Removing a separator from the bookmarks menu throw "aNode is null"

Status: VERIFIED FIXED

(Firefox :: Bookmarks & History, defect)

Description

[Marco Bonardo [:mak]]

STR:
- add a separator into bookmarks menu
- right click it and choose delete from the context menu

Error: aNode is null
Source file: chrome://browser/content/places/utils.js
Line: 426
 ----------
Error: aNode is null
Source file: chrome://browser/content/places/utils.js
Line: 426
 ----------
Error: '[JavaScript Error: "aNode is null" {file: "chrome://browser/content/places/utils.js" line: 426}]' when calling method: [nsIController::isCommandEnabled] = NS_ERROR_XPC_JAVASCRIPT_ERROR_WITH_DETAILS
Source file: chrome://browser/content/places/controller.js
Line: 1359

Comment 1

[Marco Bonardo [:mak]]

this feels like having the same cause as Bug 403263, since with that patch in i don't see that anymore... could be a bad _selection value

Comment 2

[Marco Bonardo [:mak]]

to reproduce the separator should be near a folder, probably the first item after a folder, or however between folders.

Comment 3

[Asaf Romano (gone)]

Fixed in bug 403263. Marco, please verify.

Comment 4

[Tracy Walker [:tracy]]

verified with Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9b4pre)
Gecko/2008022704 Minefield/3.0b4pre 

Comment 5

[Aakash Desai [:aakashd]]

Test case https://litmus.mozilla.org/show_test.cgi?id=6079 was updated to regression test for rel 3.1 test run. Test case https://litmus.mozilla.org/show_test.cgi?id=4121 was updated to regression test for rel3.0 test run.

Comment 6

[Gervase Markham [:gerv]]

Bug 451915 - move Firefox/Places bugs to Firefox/Bookmarks and History. Remove all bugspam from this move by filtering for the string "places-to-b-and-h".

In Thunderbird 3.0b, you do that as follows:
Tools | Message Filters
Make sure the correct account is selected. Click "New"
Conditions: Body   contains   places-to-b-and-h
Change the action to "Delete Message".
Select "Manually Run" from the dropdown at the top.
Click OK.

Select the filter in the list, make sure "Inbox" is selected at the bottom, and click "Run Now". This should delete all the bugspam. You can then delete the filter.

Gerv