Closed Bug 418838 Opened 14 years ago Closed 14 years ago

Expired visits unnecessarily reset frecencies to -1

Categories

(Firefox :: Address Bar, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
Firefox 3 beta4

People

(Reporter: Mardak, Assigned: Mardak)

References

Details

Attachments

(1 file)

When we expire visits for a page, we reset the frecency to -1 because potentially we cleared out all its visits. But we don't need to be so aggressive in resetting because we can check if the place still has visits and/or bookmarks. If so, we can reuse the frecency as a better estimate than just -1.

Patch is part of bug 417810.
This is one cause for bug 417810 which is blocking+
Flags: blocking-firefox3?
Attached patch v1Splinter Review
Assignee: nobody → edilee
Status: NEW → ASSIGNED
Attachment #304750 - Flags: review?(dietrich)
Comment on attachment 304750 [details] [diff] [review]
v1

r=me, thanks
Attachment #304750 - Flags: review?(dietrich) → review+
Checking in toolkit/components/places/src/nsNavHistoryExpire.cpp;
/cvsroot/mozilla/toolkit/components/places/src/nsNavHistoryExpire.cpp,v  <--  nsNavHistoryExpire.cpp
new revision: 1.41; previous revision: 1.40
done
Status: ASSIGNED → RESOLVED
Closed: 14 years ago
Flags: blocking-firefox3?
Resolution: --- → FIXED
Target Milestone: --- → Firefox 3 beta4
You need to log in before you can comment on or make changes to this bug.