From Bugzilla Helper:
User-Agent: Mozilla/5.0 (X11; U; FreeBSD 4.0-STABLE i386; en-US; m15)
There's a table used as a left-side navigation bar.
The table specification says "hspace=6". There is
no horizontal space left between the table and the
text that flows around it.
This (of course) looks different with Netscape 4.73...
Oh, Netscape 6 beta for Linux has the same problem. Not sure
which version though.
Steps to Reproduce:
confirmed on NT with 060708 moz bits. updating component
Created attachment 9907 [details]
simple example using hspace on floating table
Created attachment 9909 [details] [diff] [review]
patch to fix table portion of the bug
Marc, I've attached a patch that I was hoping would fix the problem. However,
the MapAttributesInto inside nsHTMLTableElement is losing the hspace attribute
even though StringToAttribute is setting it.
Chris, you were so close! GetMappedAttributeImpact has to handle the hspace and
set the impact hint like it would for height or align or width...
Should we handle vspace as well? Seems like a natural next-bug if we don't
handle that one now too.
Created attachment 9913 [details] [diff] [review]
New patch that maps hspace to style correctly
I didn't do vspace because Buster mentioned that if it goes into margins then
those vertical margins will collapse whereas vspace may not collapse. But I
guess it is better to have a bug like that in quirks mode than to not have the
functionality (assumming that Nav support vspace on tables). So, I guess it is
probably right to do vspace as well.
Nav does honor the vspace attribute - I'll add that too, mapped to top and
bottom margins, and then I'll attach that patch for you to check out.
Created attachment 9979 [details]
New testcase showing hspace and vspace
Created attachment 9980 [details] [diff] [review]
Patch for vspace and hspace support in QuirkMode...
Nominating for nsbeta2: very simple fix: quirk mode only.
fix is in. (nsHTMLTableElement.cpp)
Verified with 2000-07-05-09.