41893 - hspace and vspace attributes ignored on tables

Status: VERIFIED FIXED

(Core :: Layout: Tables, defect, P3)

Description

[David Muir Sharnoff]

From Bugzilla Helper:
User-Agent: Mozilla/5.0 (X11; U; FreeBSD 4.0-STABLE i386; en-US; m15)
BuildID:    2000030708

There's a table used as a left-side navigation bar.
The table specification says "hspace=6".  There is
no horizontal space left between the table and the
text that flows around it.

This (of course) looks different with Netscape 4.73...

Oh, Netscape 6 beta for Linux has the same problem.  Not sure
which version though.




Reproducible: Always
Steps to Reproduce:
1.visit url
2.
3.

Comment 1

[Asa Dotzler [:asa]]

confirmed on NT with 060708 moz bits. updating component

Comment 2

[karnaze (gone)]

Attachment: simple example using hspace on floating table

Comment 3

[karnaze (gone)]

Attachment: patch to fix table portion of the bug

Comment 4

[karnaze (gone)]

Marc, I've attached a patch that I was hoping would fix the problem. However, 
the MapAttributesInto inside nsHTMLTableElement is losing the hspace attribute 
even though StringToAttribute is setting it.

Comment 5

[Marc Attinasi]

Chris, you were so close! GetMappedAttributeImpact has to handle the hspace and 
set the impact hint like it would for height or align or width...

Should we handle vspace as well? Seems like a natural next-bug if we don't 
handle that one now too.

Comment 6

[Marc Attinasi]

Attachment: New patch that maps hspace to style correctly

Comment 7

[karnaze (gone)]

I didn't do vspace because Buster mentioned that if it goes into margins then 
those vertical margins will collapse whereas vspace may not collapse. But I 
guess it is better to have a bug like that in quirks mode than to not have the 
functionality (assumming that Nav support vspace on tables). So, I guess it is 
probably right to do vspace as well.

Comment 8

[Marc Attinasi]

Nav does honor the vspace attribute - I'll add that too, mapped to top and 
bottom margins, and then I'll attach that patch for you to check out.

Comment 9

[Marc Attinasi]

Attachment: New testcase showing hspace and vspace

Comment 10

[Marc Attinasi]

Attachment: Patch for vspace and hspace support in QuirkMode...

Comment 11

[Marc Attinasi]

Nominating for nsbeta2: very simple fix: quirk mode only.

Comment 12

[Peter Trudelle]

nsbeta2+

Comment 13

[Marc Attinasi]

fix is in. (nsHTMLTableElement.cpp)

Comment 14

[Prashant Desale]

Verified with 2000-07-05-09.