Closed Bug 41893 Opened 20 years ago Closed 20 years ago

hspace and vspace attributes ignored on tables

Categories

(Core :: Layout: Tables, defect, P3, trivial)

Other
All
defect

Tracking

()

VERIFIED FIXED

People

(Reporter: bugzilla, Assigned: attinasi)

References

()

Details

(Whiteboard: [nsbeta2+])

Attachments

(5 files)

From Bugzilla Helper:
User-Agent: Mozilla/5.0 (X11; U; FreeBSD 4.0-STABLE i386; en-US; m15)
BuildID:    2000030708

There's a table used as a left-side navigation bar.
The table specification says "hspace=6".  There is
no horizontal space left between the table and the
text that flows around it.

This (of course) looks different with Netscape 4.73...

Oh, Netscape 6 beta for Linux has the same problem.  Not sure
which version though.




Reproducible: Always
Steps to Reproduce:
1.visit url
2.
3.
confirmed on NT with 060708 moz bits. updating component
Assignee: asa → karnaze
Status: UNCONFIRMED → NEW
Component: Browser-General → HTMLTables
Ever confirmed: true
OS: FreeBSD → All
QA Contact: doronr → desale
Marc, I've attached a patch that I was hoping would fix the problem. However, 
the MapAttributesInto inside nsHTMLTableElement is losing the hspace attribute 
even though StringToAttribute is setting it.
Assignee: karnaze → attinasi
Chris, you were so close! GetMappedAttributeImpact has to handle the hspace and 
set the impact hint like it would for height or align or width...

Should we handle vspace as well? Seems like a natural next-bug if we don't 
handle that one now too.
Status: NEW → ASSIGNED
Target Milestone: --- → M18
I didn't do vspace because Buster mentioned that if it goes into margins then 
those vertical margins will collapse whereas vspace may not collapse. But I 
guess it is better to have a bug like that in quirks mode than to not have the 
functionality (assumming that Nav support vspace on tables). So, I guess it is 
probably right to do vspace as well.
Nav does honor the vspace attribute - I'll add that too, mapped to top and 
bottom margins, and then I'll attach that patch for you to check out.
Summary: no space left around table → hspace and vspace attributes ignored on tables
Nominating for nsbeta2: very simple fix: quirk mode only.
Keywords: nsbeta2
nsbeta2+
Whiteboard: [nsbeta2+]
fix is in. (nsHTMLTableElement.cpp)
Status: ASSIGNED → RESOLVED
Closed: 20 years ago
Resolution: --- → FIXED
Verified with 2000-07-05-09.
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.