hspace and vspace attributes ignored on tables

VERIFIED FIXED in M18

Status

()

Core
Layout: Tables
P3
trivial
VERIFIED FIXED
17 years ago
17 years ago

People

(Reporter: David Muir Sharnoff, Assigned: Marc Attinasi)

Tracking

Trunk
Other
All
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [nsbeta2+], URL)

Attachments

(5 attachments)

(Reporter)

Description

17 years ago
From Bugzilla Helper:
User-Agent: Mozilla/5.0 (X11; U; FreeBSD 4.0-STABLE i386; en-US; m15)
BuildID:    2000030708

There's a table used as a left-side navigation bar.
The table specification says "hspace=6".  There is
no horizontal space left between the table and the
text that flows around it.

This (of course) looks different with Netscape 4.73...

Oh, Netscape 6 beta for Linux has the same problem.  Not sure
which version though.




Reproducible: Always
Steps to Reproduce:
1.visit url
2.
3.

Comment 1

17 years ago
confirmed on NT with 060708 moz bits. updating component
Assignee: asa → karnaze
Status: UNCONFIRMED → NEW
Component: Browser-General → HTMLTables
Ever confirmed: true
OS: FreeBSD → All
QA Contact: doronr → desale

Comment 2

17 years ago
Created attachment 9907 [details]
simple example using hspace on floating table

Comment 3

17 years ago
Created attachment 9909 [details] [diff] [review]
patch to fix table portion of the bug

Comment 4

17 years ago
Marc, I've attached a patch that I was hoping would fix the problem. However, 
the MapAttributesInto inside nsHTMLTableElement is losing the hspace attribute 
even though StringToAttribute is setting it.
Assignee: karnaze → attinasi
(Assignee)

Comment 5

17 years ago
Chris, you were so close! GetMappedAttributeImpact has to handle the hspace and 
set the impact hint like it would for height or align or width...

Should we handle vspace as well? Seems like a natural next-bug if we don't 
handle that one now too.
Status: NEW → ASSIGNED
Target Milestone: --- → M18
(Assignee)

Comment 6

17 years ago
Created attachment 9913 [details] [diff] [review]
New patch that maps hspace to style correctly

Comment 7

17 years ago
I didn't do vspace because Buster mentioned that if it goes into margins then 
those vertical margins will collapse whereas vspace may not collapse. But I 
guess it is better to have a bug like that in quirks mode than to not have the 
functionality (assumming that Nav support vspace on tables). So, I guess it is 
probably right to do vspace as well.
(Assignee)

Comment 8

17 years ago
Nav does honor the vspace attribute - I'll add that too, mapped to top and 
bottom margins, and then I'll attach that patch for you to check out.
Summary: no space left around table → hspace and vspace attributes ignored on tables
(Assignee)

Comment 9

17 years ago
Created attachment 9979 [details]
New testcase showing hspace and vspace
(Assignee)

Comment 10

17 years ago
Created attachment 9980 [details] [diff] [review]
Patch for vspace and hspace support in QuirkMode...
(Assignee)

Comment 11

17 years ago
Nominating for nsbeta2: very simple fix: quirk mode only.
Keywords: nsbeta2

Comment 12

17 years ago
nsbeta2+
Whiteboard: [nsbeta2+]
(Assignee)

Comment 13

17 years ago
fix is in. (nsHTMLTableElement.cpp)
Status: ASSIGNED → RESOLVED
Last Resolved: 17 years ago
Resolution: --- → FIXED

Comment 14

17 years ago
Verified with 2000-07-05-09.
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.