Closed Bug 419016 Opened 17 years ago Closed 17 years ago

Space between the votes text and period is visually unappealing and confusing.

Categories

(Bugzilla :: User Interface, defect)

Product:
Bugzilla
Component:
User Interface
Version:
3.1.2
Type:
defect
Priority:
Not set
Severity:
minor

Tracking

()

Status:
RESOLVED FIXED
Milestone:
Bugzilla 3.2

People

(Reporter: guy.pyrzak, Assigned: guy.pyrzak)

Details

Attachments

(2 files, 6 obsolete files)

The bug
5.30 KB, image/png
Details
Patch V6
1.65 KB, patch
LpSolit
: review+
Details | Diff | Splinter Review
Minor bug. I even have the patch ready. Should be fixed and put in for 3.2
Attached image The bug —
Attached file Patch v1 (obsolete) —
chomps the whitespace that looks so horrid.
Attachment #304965 - Flags: review?(mkanat)
Attached patch Patch v1 (obsolete) — — Splinter Review
chomps the whitespace that looks so horrid.
Attachment #304966 - Flags: review?(mkanat)
Attachment #304965 - Attachment is obsolete: true
Attachment #304965 - Flags: review?(mkanat)
fixed the name. That's what happens when you file bugs at 5am.
Summary: Space between the votes text and period is annoying and dumb looking → Space between the votes text and period is visually unappealing and confusing.
Attached patch Patch v2 (obsolete) — — Splinter Review
seemed like a better way of doing it once i thought about it for 2 seconds
Attachment #304966 - Attachment is obsolete: true
Attachment #304967 - Flags: review?(mkanat)
Attachment #304966 - Flags: review?(mkanat)
Comment on attachment 304967 [details] [diff] [review] Patch v2 >+ [% bug.votes %] vote >+ [%IF bug.votes > 1 %]s[% END %]</a>. As discussed with the L10n team at our last meeting, this way to handle plurals doesn't work in several languages. We should stop using these tricks and write: [% IF bug.votes > 1 %] votes [% ELSE %] vote [% END %]
Attachment #304967 - Flags: review?(mkanat) → review-
Severity: normal → minor
OS: Mac OS X → All
Hardware: PC → All
Attached patch Patch v3 (obsolete) — — Splinter Review
Good catch. here is the change with the recommendations made. Also we should update the template documentation to mention this. I also realized "0 vote" makes no sense either which is how I had the logic working.
Attachment #304967 - Attachment is obsolete: true
Attachment #305032 - Flags: review?(mkanat)
We should get rid of the period. "with 34 votes" is not a sentence after all.
Status: NEW → ASSIGNED
Attached patch Patch V4 (obsolete) — — Splinter Review
removed the periods and also made a fix to the users part as well.
Attachment #305032 - Attachment is obsolete: true
Attachment #305032 - Flags: review?(mkanat)
Attachment #305035 - Flags: review?(mkanat)
Comment on attachment 305035 [details] [diff] [review] Patch V4 Note that "total user" doesn't make sense either.
Attachment #305035 - Flags: review?(mkanat) → review-
Oh, and you need a space in "[%IF". (That's just a nit.)
(In reply to comment #6) > >+ [% bug.votes %] vote > >+ [%IF bug.votes > 1 %]s[% END %]</a>. > As discussed with the L10n team at our last meeting, this way to handle plurals > doesn't work in several languages. We should stop using these tricks and write: Good point, this belongs to bug 412161
Attached patch Patch V5 (obsolete) — — Splinter Review
Attachment #305035 - Attachment is obsolete: true
Attachment #314175 - Flags: review?(mkanat)
Attachment #314175 - Flags: review?(LpSolit)
Comment on attachment 314175 [details] [diff] [review] Patch V5 >+ [% bug.cc.size || 0 FILTER html%]&nbsp; >+ [% IF bug.cc.size == 1 %] >+ user The UI now displays two spaces, one due to &nbsp; and a second one due to normal whitespaces/newlines in the template. That's not really nice.
Attached patch Patch V6 — — Splinter Review
had an extra space.
Attachment #314175 - Attachment is obsolete: true
Attachment #314180 - Flags: review?(mkanat)
Attachment #314180 - Flags: review?(LpSolit)
Attachment #314175 - Flags: review?(mkanat)
Attachment #314175 - Flags: review?(LpSolit)
Comment on attachment 314180 [details] [diff] [review] Patch V6 >+ [% bug.cc.size || 0 FILTER html%] Nit: add a space before %]. This can be fixed on checkin. r=LpSolit
Attachment #314180 - Flags: review?(mkanat)
Attachment #314180 - Flags: review?(LpSolit)
Attachment #314180 - Flags: review+
Flags: approval+
/cvsroot/mozilla/webtools/bugzilla/template/en/default/bug/edit.html.tmpl,v <-- edit.html.tmpl new revision: 1.121; previous revision: 1.120 done
Status: ASSIGNED → RESOLVED
Closed: 17 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: