Space between the votes text and period is visually unappealing and confusing.

RESOLVED FIXED in Bugzilla 3.2

Status

()

--
minor
RESOLVED FIXED
11 years ago
11 years ago

People

(Reporter: guy.pyrzak, Assigned: guy.pyrzak)

Tracking

3.1.2
Bugzilla 3.2
Bug Flags:
approval +

Details

Attachments

(2 attachments, 6 obsolete attachments)

(Assignee)

Description

11 years ago
Minor bug. I even have the patch ready. Should be fixed and put in for 3.2
(Assignee)

Comment 1

11 years ago
Created attachment 304964 [details]
The bug
(Assignee)

Comment 2

11 years ago
Created attachment 304965 [details]
Patch v1

chomps the whitespace that looks so horrid.
Attachment #304965 - Flags: review?(mkanat)
(Assignee)

Comment 3

11 years ago
Created attachment 304966 [details] [diff] [review]
Patch v1

chomps the whitespace that looks so horrid.
Attachment #304966 - Flags: review?(mkanat)
(Assignee)

Updated

11 years ago
Attachment #304965 - Attachment is obsolete: true
Attachment #304965 - Flags: review?(mkanat)
(Assignee)

Comment 4

11 years ago
fixed the name. That's what happens when you file bugs at 5am.
Summary: Space between the votes text and period is annoying and dumb looking → Space between the votes text and period is visually unappealing and confusing.
(Assignee)

Comment 5

11 years ago
Created attachment 304967 [details] [diff] [review]
Patch v2

seemed like a better way of doing it once i thought about it for 2 seconds
Attachment #304966 - Attachment is obsolete: true
Attachment #304967 - Flags: review?(mkanat)
Attachment #304966 - Flags: review?(mkanat)

Comment 6

11 years ago
Comment on attachment 304967 [details] [diff] [review]
Patch v2

>+                  [% bug.votes %] vote
>+                  [%IF bug.votes > 1 %]s[% END %]</a>. 

As discussed with the L10n team at our last meeting, this way to handle plurals doesn't work in several languages. We should stop using these tricks and write:

[% IF bug.votes > 1 %]
  votes
[% ELSE %]
  vote
[% END %]
Attachment #304967 - Flags: review?(mkanat) → review-

Updated

11 years ago
Severity: normal → minor
OS: Mac OS X → All
Hardware: PC → All
(Assignee)

Comment 7

11 years ago
Created attachment 305032 [details] [diff] [review]
Patch v3

Good catch. here is the change with the recommendations made. Also we should update the template documentation to mention this. I also realized "0 vote" makes no sense either which is how I had the logic working.
Attachment #304967 - Attachment is obsolete: true
Attachment #305032 - Flags: review?(mkanat)

Comment 8

11 years ago
We should get rid of the period. "with 34 votes" is not a sentence after all.
Status: NEW → ASSIGNED
(Assignee)

Comment 9

11 years ago
Created attachment 305035 [details] [diff] [review]
Patch V4

removed the periods and also made a fix to the users part as well.
Attachment #305032 - Attachment is obsolete: true
Attachment #305032 - Flags: review?(mkanat)
(Assignee)

Updated

11 years ago
Attachment #305035 - Flags: review?(mkanat)
Comment on attachment 305035 [details] [diff] [review]
Patch V4

Note that "total user" doesn't make sense either.
Attachment #305035 - Flags: review?(mkanat) → review-
Oh, and you need a space in "[%IF". (That's just a nit.)

Comment 12

11 years ago
(In reply to comment #6)
> >+                  [% bug.votes %] vote
> >+                  [%IF bug.votes > 1 %]s[% END %]</a>. 

> As discussed with the L10n team at our last meeting, this way to handle plurals
> doesn't work in several languages. We should stop using these tricks and write:

Good point, this belongs to bug 412161
(Assignee)

Comment 13

11 years ago
Created attachment 314175 [details] [diff] [review]
Patch V5
Attachment #305035 - Attachment is obsolete: true
Attachment #314175 - Flags: review?(mkanat)
Attachment #314175 - Flags: review?(LpSolit)

Comment 14

11 years ago
Comment on attachment 314175 [details] [diff] [review]
Patch V5

>+        [% bug.cc.size || 0  FILTER html%]&nbsp; 
>+        [% IF bug.cc.size == 1 %]
>+          user

The UI now displays two spaces, one due to &nbsp; and a second one due to normal whitespaces/newlines in the template. That's not really nice.
(Assignee)

Comment 15

11 years ago
Created attachment 314180 [details] [diff] [review]
Patch V6

had an extra space.
Attachment #314175 - Attachment is obsolete: true
Attachment #314180 - Flags: review?(mkanat)
Attachment #314180 - Flags: review?(LpSolit)
Attachment #314175 - Flags: review?(mkanat)
Attachment #314175 - Flags: review?(LpSolit)

Comment 16

11 years ago
Comment on attachment 314180 [details] [diff] [review]
Patch V6

>+        [% bug.cc.size || 0  FILTER html%] 

Nit: add a space before %]. This can be fixed on checkin. r=LpSolit
Attachment #314180 - Flags: review?(mkanat)
Attachment #314180 - Flags: review?(LpSolit)
Attachment #314180 - Flags: review+

Updated

11 years ago
Flags: approval+
(Assignee)

Comment 17

11 years ago
/cvsroot/mozilla/webtools/bugzilla/template/en/default/bug/edit.html.tmpl,v  <--  edit.html.tmpl
new revision: 1.121; previous revision: 1.120
done
Status: ASSIGNED → RESOLVED
Last Resolved: 11 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.