419074 - Show different install buttons depending on add-on/app compatibility

Status: VERIFIED FIXED

(addons.mozilla.org Graveyard :: Public Pages, defect)

Description

[Madhava Enros [:madhava]]

See attachment.  (the strings in the attachment refer specifically to Firefox, but we can substitute the name of the relevant app for other apps)

Given that we can detect what version of a browser with which a user is coming to AMO, we can know whether the latest version of the add-on of interest is compatible with the user's browser.  When the add-on is not compatible, we should show the appropriate one of the two cases shown in the attachment.

The "Add to APP" buttons should be disabled, not just greyed out (ie - no hover state)

Comment 1

[Madhava Enros [:madhava]]

Attachment: what to show in the two incompatible add-on cases

Comment 2

[Philip Chee]

I use SeaMonkey to download Firefox specific extensions. Will this affect me?

Comment 3

[Fred Wenzel [:wenzel]]

Madhava: Philip is raising a good point here. What if I really want to download this extension, in spite of my current browser being incompatible? This can happen for people running nightly builds, or people downloading stuff from an incompatible computer in order to deploy it to another one...

Another concern of mine is if this kind of per-user UA sniffing is even possible through the Netscalers. This may work for the first person accessing the page, but other people will get served the same copy of the page, even if their browser version is another one. (I guess we could do all this in Javascript though).

Comment 6

[Michael Morgan [:morgamic]]

Marked two other bugs as dupes because they all depend on CSS changes to this bug.

Comment 7

[Madhava Enros [:madhava]]

Fred - our solution for the "want to get an incompatible add-on" use-case is
for users to go to the "See Version History" page, where we don't do any
browser/app version detection.  The idea is that all versions of the add-on
would be listed there, so the user who knows what he/she's doing can find the
appropriate one here.

This may not be the ideal solution, but I don't want to un-streamline the task
flow for the typical "just give me the right version" user to privilege a real
but non-primary case like this.

Comment 8

[Fred Wenzel [:wenzel]]

Thanks for the clarification, Madhava. I will see what I can do.

Another thing that concerns me is that we need l10n for this, and we have just published some "late l10n" strings and I don't think we should do that again before the push. Because of this, I think this code will have to land post-release. Opinions?

Comment 9

[Madhava Enros [:madhava]]

At the moment, this is means of telling users whether a given add-on will be compatible with their version of firefox/other app.  If we don't do this for 3.2, we need to have some other means of doing this.  One way or another, we have to communicate this information.

Comment 10

[Basil Hashem [:baz]]

We absolutely need to do this before we release v3.2 - we'll followup with L10N when needed but without this we will be confusing our Fx 2 and Fx 3 users.

Comment 11

[Fred Wenzel [:wenzel]]

Okay, understood, I'll get this in asap; I'll do l10n fallback to English for now. Also sorry I didn't get back to you earlier, it seems I missed Madhava's message :(

Comment 12

[Fred Wenzel [:wenzel]]

A first patch with some Javascript magic is in r11391, showing these hints on the addons details page only.

Comment 13

[Fred Wenzel [:wenzel]]

In r11392, I am showing the hints on all pages (but the versions page).

r11393 contains l10n including English fallback.

One question: For the "upgrade" link I am pointing to getfirefox.com -- is that appropriate or do we want to link to a more specific page?

Comment 14

[Madhava Enros [:madhava]]

Attachment: some text wrapping issues

There are some issues with the way that text wraps in the area that surrounds the disabled button.  See the attached image.

Comment 15

[Ryan Doherty (:rdoherty)]

Attachment: Overlap issue

Just noticed that we're showing an install button over the 'addon not available' messaging. (Linux button)

Comment 16

[Fred Wenzel [:wenzel]]

(In reply to comment #14)
> There are some issues with the way that text wraps in the area that surrounds
> the disabled button.  See the attached image.

All right, I fixed the "two lines running into each other" issue by removing the "older version" message when the other message is present anyway, since both together don't make much sense. r11404.

The other issue (word wrap) I don't think I can fix: It's caused by the install box being 210 pixels wide. I can make it wider for en-US to fit in, but in other languages the very same issue is just asking to occur, no matter how wide I make the box. So there's not really much we can do about that :-/

I also noticed the deactivated install buttons are not centered, but Craig's CSS has very strict, fixed sizes everywhere and thus so far I have been unable to figure out how to achieve a centered button without breaking about 50 more things *sigh*.

Comment 17

[Madhava Enros [:madhava]]

Hm.  It's not that the text is wrapping at all that the problem so much as where it's wrapping.  Can we have it wrap at the width of the install button or the install button plus a few pixels on each side?  Actually, maybe I shouldn't really be suggesting technical solutions.  I'll attach a mockup with what I mean.

Comment 18

[Madhava Enros [:madhava]]

Attachment: more about text wrapping

Comment 19

[Fred Wenzel [:wenzel]]

(In reply to comment #15)
> Just noticed that we're showing an install button over the 'addon not
> available' messaging. (Linux button)

Release early, release often: In r11406, this is fixed.

Comment 20

[Fred Wenzel [:wenzel]]

Madhava: Thanks for the mockup, I reduced the width for these install boxes so that the text wraps more reasonably there. r11408.

Unless I missed something, this is FIXED (yay!). But please reopen if you notice anything unexpected.

Comment 21

[Stephen Donner [:stephend] Not actively reading bugmail]

Verified FIXED; I also think this is fixed, based on my testing.  (Sorry for missing comment 0 during my initial testing, which is now bug 425476.)

Comment 23

[Philip Chee]

Is this on the live AMO site? Because I can go visit (using SeaMonkey) https://addons.mozilla.org/en-US/seamonkey/addon/1729/ and get a green "Add to SeaMonkey" button despite the extension being Firefox only. Note javascipt is turned on and I don't have any cookie blocking as far as I know.

Comment 24

[Stephen Donner [:stephend] Not actively reading bugmail]

(In reply to comment #23)
> Is this on the live AMO site? Because I can go visit (using SeaMonkey)
> https://addons.mozilla.org/en-US/seamonkey/addon/1729/ and get a green "Add to
> SeaMonkey" button despite the extension being Firefox only. Note javascipt is
> turned on and I don't have any cookie blocking as far as I know.

We literally just SVN-updated AMO to 3.21; please let us know if you see problems, but this is fixed for me with the update: http://img267.imageshack.us/my.php?image=picture5xx8.png

Comment 25

[Philip Chee]

> We literally just SVN-updated AMO to 3.21; please let us know if you see
> problems, but this is fixed for me with the update:
> http://img267.imageshack.us/my.php?image=picture5xx8.png

You seem to be using Firefox, Could you try visiting https://addons.mozilla.org/en-US/seamonkey/addon/1729/ using SeaMonkey? Thanks.

Note if I go to https://addons.mozilla.org/en-US/firefox/addon/1729/ I do get a "Download Now" button.

Inference: your browser sniffing is still sub-optimal.

Comment 26

[Fred Wenzel [:wenzel]]

If I understand this right, you expect not to be seeing a page at all when you open this extension's details page on the seamonkey section, because it is incompatible with SeaMonkey?

Comment 27

[Philip Chee]

> If I understand this right, you expect not to be seeing a page at all when you
> open this extension's details page on the seamonkey section, because it is
> incompatible with SeaMonkey?

No you understand wrongly. I am expecting a "Download Now" button instead of a "Add to SeaMonkey" button.