419097 - Mac-only removal of view button icons will be a pain for extension developers

Status: VERIFIED FIXED

(Firefox :: Theme, defect)

Description

[Florian Quèze [:florian]]

Attachment: patch v1

The new Mac theme doesn't have icons any more for the view buttons in Page Info but extension authors will still provide them because they are needed on Windows on Linux.

I fear fixing this in the extensions would require either an ugly hack or an additionnal css file registered only for Mac OS in the install manifest of the extensions.

I think we should prevent this bug in pinstripe. Patch attached.

Comment 1

[Asaf Romano (gone)]

Can you simplify the selector to just ".viewButtonIcon"?

Comment 2

[Asaf Romano (gone)]

Comment on attachment 305071 [details] [diff] [review]
patch v1

r=mano with that fixed.

Comment 3

[Florian Quèze [:florian]]

Attachment: patch v2 (ready for checkin)

Comment 4

[Mike Beltzner [:beltzner, not reading bugmail]]

Comment on attachment 305194 [details] [diff] [review]
patch v2 (ready for checkin)

a=beltzner

Comment 5

[Florian Quèze [:florian]]

Checking in browser/themes/pinstripe/browser/pageInfo.css;
/cvsroot/mozilla/browser/themes/pinstripe/browser/pageInfo.css,v  <--  pageInfo.css
new revision: 1.13; previous revision: 1.12
done

Comment 6

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Verified with Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.4; en-US; rv:1.9b4pre) Gecko/2008022704 Minefield/3.0b4pre ID:2008022704