419178 - "Port" "Bug 389290 – Bookmarks Menu - dropmarker missing" to SeaMonkey

Status: RESOLVED WONTFIX

(SeaMonkey :: Bookmarks & History, defect)

Description

[Serge Gautherie (:sgautherie)]

[Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.9a5pre) Gecko/20070515 SeaMonkey/1.5a] (nightly) (W2Ksp4)

No bug.

[Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.9b4pre) Gecko/2008022202 SeaMonkey/2.0a1pre] (nightly) (W2Ksp4)

Bug.

Bug 389290 comment 10:
{{
[...]
File a SeaMonkey bug for adapting their bookmarksToolbar.css to use
the new binding for the bookmarks menu and bookmarksMenu.js to configure it as
Places does.
}}

Comment 1

[Ian Neal]

I see the the dropmarker in the default theme, which theme are you using? Does it still happen on a recent trunk nightly?

Comment 2

[Serge Gautherie (:sgautherie)]

[Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.9b4pre) Gecko/2008022202
SeaMonkey/2.0a1pre] (nightly) (W2Ksp4)
[Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.9.1a2pre) Gecko/20080819081634 SeaMonkey/2.0a1pre] (home, optim default) (W2Ksp4)

Confirmed with new profile(s):
*Default (Classic) theme.
*Bookmark Manager works fine: has small drop marker.
*(Bookmarks and Personal Toolbar) Menus don't: have no full width line.

NB: Might be related to the other (Thread Manager) regressions !?

Comment 3

[Robert Kaiser]

I think we won't block Alpha 1 on this UI glitch, but if a patch comes up in the next few days, we're probably good to approve it so it makes the alpha.

Comment 4

[Robert Kaiser]

This bug is open but targeted for seamonkey2.0a1, which has been released a long time ago. Please set the target milestone to an appropriate value, "---" if it has no specific target.

Comment 5

[Ian Neal]

Not blocking 2.0 but would consider a patch. Nominate for wanted 2.1 if you think it is appropriate. Is bug 465323 a dupe of this one?

Comment 7

[Serge Gautherie (:sgautherie)]

(In reply to comment #6)
> *** Bug 465323 has been marked as a duplicate of this bug. ***

Ftr:
{
Comment #3 From  [e-mail]   2009-01-29 13:21:45 PDT

This is because toolkit uses -moz-appearance for toolbarbuttons so that you
can't alter the borders to provide drop feedback.

I don't know if or how Firefox provides drop feedback.

Comment #4 From Philip Chee 2009-02-23 06:54:23 PDT

I think they use a drag-drop indicator similar to the way the tab drag&drop
code.
}

Comment 8

[Robert Kaiser]

Please re-nominate for 2.1 if it doesn't make 2.0

Comment 9

[Philip Chee]

Attachment: Patch vA1.0 Proposed kwikfix for SM2.0

Minimal wallpaper patch for 2.0

 menu.bookmark-item,
 menuitem.bookmark-item {
   border-top: 1px solid transparent !important;
   border-bottom: 1px solid transparent !important;
+  -moz-appearance: none;
 }

Comment 10

[Philip Chee]

Comment on attachment 401832 [details] [diff] [review]
Patch vA1.0 Proposed kwikfix for SM2.0

Oops. Wrong mime type.

Comment 11

[[e-mail]]

Comment on attachment 401832 [details] [diff] [review]
Patch vA1.0 Proposed kwikfix for SM2.0

Isn't this going to look really ugly on Luna?

Comment 12

[Philip Chee]

Attachment: Luna bookmark-items with -moz-appearance: none;

> (From update of attachment 401832 [details] [diff] [review])
> Isn't this going to look really ugly on Luna?

I can't tell the difference. The visual appearance does not appear to change with or without the -moz-appearance: none; rule. Does it look really bad on your PC? Perhaps it's just my graphics card.

Comment 13

[[e-mail]]

Comment on attachment 401832 [details] [diff] [review]
Patch vA1.0 Proposed kwikfix for SM2.0

It might look passable with Luna but it's no good on a typical Linux theme.

Comment 14

[Philip Chee]

> It might look passable with Luna but it's no good on a typical Linux theme.

How about I use:
:-moz-system-metric(windows-classic) and :-moz-system-metric(windows-default-theme)
To limit the application, or is this too hacky?

Comment 15

[Philip Chee]

Mozilla/5.0 (Windows NT 6.1; WOW64; rv:2.0b8pre) Gecko/20101213 SeaMonkey/2.1b2pre

Appears to be WFM due to the move to Places Bookmarks.

WONTFIX for the SeaMonkey 2.0 branch.