419218 - bookmark or bookmarks folder properties dialog is using wrong icon for "save changes" button

Status: VERIFIED FIXED

(Firefox :: Bookmarks & History, defect)

Description

[u294409]

User-Agent:       Mozilla/5.0 (X11; U; Linux i686; pl; rv:1.9b4pre) Gecko/2008022304 Fedora/8 (Werewolf) Minefield/3.0b4pre
Build Identifier: Mozilla/5.0 (X11; U; Linux i686; pl; rv:1.9b4pre) Gecko/2008022304 Fedora/8 (Werewolf) Minefield/3.0b4pre

gtk-ok icon used instead of gtk-save

Reproducible: Always

Actual Results:  
wrong icon

Expected Results:  
good icon (;

Comment 1

[Andrés Delfino]

Jakub, please set version to Trunk.

Comment 2

[Andrés Delfino]

I can confirm with:
Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9b5pre) Gecko/2008031103 Minefield/3.0b5pre

Comment 3

[u294409]

As you wish, master :D .

Comment 4

[Dão Gottwald [:dao]]

Attachment: patch

Comment 5

[Marco Bonardo [:mak]]

Comment on attachment 375539 [details] [diff] [review]
patch

r+ code-wise, btw i'm not completely sure the save icon is correct for this dialog, that is effectively an OK/Cancel dialog (even if the label actually is "Save changes"). If you could ping someone from ux-team about that, would be great.

Comment 6

[Dão Gottwald [:dao]]

http://hg.mozilla.org/mozilla-central/rev/afa7d93bc26d

Comment 7

[Mike Beltzner [:beltzner, not reading bugmail]]

Comment on attachment 375539 [details] [diff] [review]
patch

a191=beltzner

Comment 8

[Dão Gottwald [:dao]]

http://hg.mozilla.org/releases/mozilla-1.9.1/rev/40c94de7da16

Comment 9

[Aakash Desai [:aakashd]]

verified FIXED on builds:


Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9.1pre) Gecko/20090527 Shiretoko/3.5pre ID:20090527031440

and

Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9.2a1pre) Gecko/20090527 Minefield/3.6a1pre ID:20090527031442

Comment 10

[Alex Faaborg [:faaborg] (Firefox UX)]

This bug's priority relative to the set of other polish bugs is:
P2 - Polish issue that is in a secondary interface, occasionally encountered, and is easily identifiable.

Secondary UI, assuming the difference between the two icons was obvious (although I'm not totally up to speed on the meaning of different gtk icons).

Comment 11

[Gervase Markham [:gerv]]

Bug 451915 - move Firefox/Places bugs to Firefox/Bookmarks and History. Remove all bugspam from this move by filtering for the string "places-to-b-and-h".

In Thunderbird 3.0b, you do that as follows:
Tools | Message Filters
Make sure the correct account is selected. Click "New"
Conditions: Body   contains   places-to-b-and-h
Change the action to "Delete Message".
Select "Manually Run" from the dropdown at the top.
Click OK.

Select the filter in the list, make sure "Inbox" is selected at the bottom, and click "Run Now". This should delete all the bugspam. You can then delete the filter.

Gerv