Closed Bug 419250 Opened 14 years ago Closed 14 years ago

Use 16x16 puzzle icon for xpinstall-install-blocked notification

Categories

(Firefox :: General, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
Firefox 3 beta4

People

(Reporter: reed, Assigned: reed)

Details

(Keywords: polish)

Attachments

(2 files)

Attached patch patch - v1Splinter Review
Spin-off from bug 418868, comment #32.
The xpinstall-install-blocked notification is using the wrong icon for the xpinstallPromptWarning notification. It is currently using chrome://mozapps/skin/xpinstall/xpinstallItemGeneric.png (32x32) when it needs a 16x16 icon like chrome://mozapps/skin/update/update.png.

See attachment 305209 [details] for a screenshot.

Changing it to use chrome://mozapps/skin/update/update.png for now, but not sure if that's what we want to continue to use... Maybe something under chrome://mozapps/skin/extensions/ ? Dunno...
Attachment #305295 - Flags: review?(gavin.sharp)
I Wondered about chrome://mozapps/skin/update/update.png myself... is this actually used for "update" (and thus needs a 16x16 update icon) or is it meant to be the 16x16 extension icon and just has a very strange name?
Attached image Old extension icon
note this is the old one, we will want an aqua style icon for pinstripe/proto
Comment on attachment 305295 [details] [diff] [review]
patch - v1

New icon for pinstripe attached by faaborg.
Attachment #305295 - Flags: review- → review?(gavin.sharp)
Attachment #305295 - Flags: review?(gavin.sharp) → review?(mano)
Attachment #305295 - Flags: approval1.9b4?
Attachment #305295 - Flags: approval1.9?
Comment on attachment 305295 [details] [diff] [review]
patch - v1

a1.9b4=beltzner
Attachment #305295 - Flags: approval1.9b4? → approval1.9b4+
Keywords: checkin-needed
Attachment #305295 - Flags: approval1.9?
Checking in browser/base/content/browser.js;
/cvsroot/mozilla/browser/base/content/browser.js,v  <--  browser.js
new revision: 1.981; previous revision: 1.980
done
Checking in toolkit/themes/pinstripe/mozapps/update/update.png;
/cvsroot/mozilla/toolkit/themes/pinstripe/mozapps/update/update.png,v  <--  update.png
new revision: 1.4; previous revision: 1.3
done
Status: ASSIGNED → RESOLVED
Closed: 14 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 3 beta4
You need to log in before you can comment on or make changes to this bug.