419250 - Use 16x16 puzzle icon for xpinstall-install-blocked notification

Status: RESOLVED FIXED

(Firefox :: General, defect)

Description

[Reed Loden [:reed]]

Attachment: patch - v1

Spin-off from bug 418868, comment #32.
The xpinstall-install-blocked notification is using the wrong icon for the xpinstallPromptWarning notification. It is currently using chrome://mozapps/skin/xpinstall/xpinstallItemGeneric.png (32x32) when it needs a 16x16 icon like chrome://mozapps/skin/update/update.png.

See attachment 305209 [details] for a screenshot.

Changing it to use chrome://mozapps/skin/update/update.png for now, but not sure if that's what we want to continue to use... Maybe something under chrome://mozapps/skin/extensions/ ? Dunno...

Comment 1

[Michael Monreal [:micmon]]

I Wondered about chrome://mozapps/skin/update/update.png myself... is this actually used for "update" (and thus needs a 16x16 update icon) or is it meant to be the 16x16 extension icon and just has a very strange name?

Comment 2

[:Gavin Sharp [email: [e-mail]]]

Comment on attachment 305295 [details] [diff] [review]
patch - v1

This is wrong on Mac.
http://lxr.mozilla.org/seamonkey/source/toolkit/themes/pinstripe/mozapps/update/update.png

Comment 3

[Alex Faaborg [:faaborg] (Firefox UX)]

Attachment: Old extension icon

note this is the old one, we will want an aqua style icon for pinstripe/proto

Comment 4

[Reed Loden [:reed]]

Comment on attachment 305295 [details] [diff] [review]
patch - v1

New icon for pinstripe attached by faaborg.

Comment 5

[Asaf Romano (gone)]

Comment on attachment 305295 [details] [diff] [review]
patch - v1

r=mano

Comment 6

[Mike Beltzner [:beltzner, not reading bugmail]]

Comment on attachment 305295 [details] [diff] [review]
patch - v1

a1.9b4=beltzner

Comment 7

[Reed Loden [:reed]]

Checking in browser/base/content/browser.js;
/cvsroot/mozilla/browser/base/content/browser.js,v  <--  browser.js
new revision: 1.981; previous revision: 1.980
done
Checking in toolkit/themes/pinstripe/mozapps/update/update.png;
/cvsroot/mozilla/toolkit/themes/pinstripe/mozapps/update/update.png,v  <--  update.png
new revision: 1.4; previous revision: 1.3
done