Closed Bug 419340 Opened 12 years ago Closed 12 years ago

Depend builds need to remove NSS exports from dist

Categories

(Firefox Build System :: General, defect)

defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: neil, Assigned: neil)

Details

Attachments

(1 file)

In the same way that we clear out dist/include to avoid stale header files confusing the compiler, we need to clear out dist/public and dist/private which are used by NSS.

For instance, bug 402773 moved several exports from dist/public/nss to dist/private/nss (which appears later in the include path), so when bug 375019 changed one of the headers depend builds failed because of the stale copy.
Attached patch Proposed patchSplinter Review
Assignee: nobody → neil
Status: NEW → ASSIGNED
Attachment #305387 - Flags: review?(ted.mielczarek)
Attachment #305387 - Flags: review?(ted.mielczarek) → review+
Attachment #305387 - Flags: approval1.9?
Comment on attachment 305387 [details] [diff] [review]
Proposed patch

a=beltzner for 1.9
Attachment #305387 - Flags: approval1.9? → approval1.9+
Fix checked in.
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Product: Core → Firefox Build System
You need to log in before you can comment on or make changes to this bug.