Closed Bug 419389 Opened 14 years ago Closed 14 years ago

Need to catch Cocoa exceptions in printing UI

Categories

(Core :: Printing: Output, defect)

Product:
Core
Component:
Printing: Output
Platform:
x86
macOS
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla1.9beta4

People

(Reporter: stanshebs, Assigned: jaas)

References

Details

Attachments

(2 files)

cleanup/rename v1.0
77.69 KB, patch
roc
: review+
roc
: superreview+
Details | Diff | Splinter Review
fix v1.0
7.84 KB, patch
roc
: superreview+
beltzner
: approval1.9b4-
Details | Diff | Splinter Review 
Although there is no ObjC/C++ code in embedding/components/printingui/src/mac, the high-level printing calls do go down into frameworks that can throw Cocoa exceptions. So they need to be wrapped like other Mac framework calls.
This removes unused files and renames the main printing prompt file to .mm. The cvs history for that file isn't important.
Assignee: nobody → joshmoz
Status: NEW → ASSIGNED
Attachment #305641 - Flags: superreview?(roc)
Attachment #305641 - Flags: superreview?(roc)
Attachment #305641 - Flags: superreview+
Attachment #305641 - Flags: review+
landed cleanup/rename v1.0
Attached patch fix v1.0 — — Splinter Review 
Still have to do the printpde plugin, I'll get that next.
Attachment #306617 - Flags: superreview?(roc)
Attachment #306617 - Flags: superreview?(roc) → superreview+
Attachment #306617 - Flags: approval1.9b4?
Comment on attachment 306617 [details] [diff] [review]
fix v1.0

Let's wait until after b4
Attachment #306617 - Flags: approval1.9b4?
Attachment #306617 - Flags: approval1.9b4-
Attachment #306617 - Flags: approval1.9?
Flags: blocking1.9+
Attachment #306617 - Flags: approval1.9?
landed "fix v1.0" on trunk, still need to do printpde plugin here
Target Milestone: --- → mozilla1.9beta4
Split PrintPDE into its own bug, 420924, turns out that is somewhat complicated.
Status: ASSIGNED → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.