Closed
Bug 419390
Opened 16 years ago
Closed 16 years ago
Need to catch Cocoa exceptions in Mac file handlers
Categories
(Core Graveyard :: File Handling, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: stanshebs, Assigned: jaas)
References
Details
Attachments
(2 files)
|
102.81 KB,
patch
|
roc
:
review+
roc
:
superreview+
|
Details | Diff | Splinter Review |
|
19.78 KB,
patch
|
roc
:
superreview+
beltzner
:
approval1.9b4-
|
Details | Diff | Splinter Review |
The Mac-specific framework calls uriloader/exthandler/mac can potentially throw Cocoa exceptions that are not caught within the framework, and thus need to be wrapped in @try-blocks like other Cocoa code. (I don't think the InternetConfig calls need it though, is self-contained.)
Assignee: nobody → joshmoz
Status: NEW → ASSIGNED
Attachment #305657 -
Flags: superreview?(roc)
Attachment #305657 -
Flags: review?(roc)
We're losing all history here. CVS renames are painful but since we're going to do this a lot, maybe we should just bite the bullet?
I said in irc last night that I was going to actually do this via cvs rename, but the patch is in add/remove format.
Comment on attachment 305657 [details] [diff] [review] cleanup/rename v1.0 this hardly needs review...
Attachment #305657 -
Flags: superreview?(roc)
Attachment #305657 -
Flags: superreview+
Attachment #305657 -
Flags: review?(roc)
Attachment #305657 -
Flags: review+
Attachment #306621 -
Flags: superreview?(roc)
Attachment #306621 -
Flags: superreview?(roc) → superreview+
Attachment #306621 -
Flags: approval1.9b4?
|
||
Comment 8•16 years ago
|
||
Comment on attachment 306621 [details] [diff] [review] fix v1.0 Let's wait until after b4
Attachment #306621 -
Flags: approval1.9b4?
Attachment #306621 -
Flags: approval1.9b4-
Attachment #306621 -
Flags: approval1.9?
Attachment #306621 -
Flags: approval1.9?
landed on trunk
Status: ASSIGNED → RESOLVED
Closed: 16 years ago
Resolution: --- → FIXED
|
||
Comment 10•16 years ago
|
||
Frankly, I don't think it's acceptable to loose the entire commit history just to rename a file. Please stop doing that. http://bonsai.mozilla.org/cvsblame.cgi?file=/mozilla/xpcom/io/nsLocalFileOSX.mm :-(
|
||
Updated•8 years ago
|
Product: Core → Core Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•