Closed Bug 419413 Opened 13 years ago Closed 13 years ago

Crash [@ CAccessibleHyperlink::get_anchorTarget() ]

Categories

(Core :: Disability Access APIs, defect)

defect
Not set
critical

Tracking

()

RESOLVED FIXED

People

(Reporter: aaronlev, Assigned: aaronlev)

Details

(Keywords: access, crash)

Crash Data

Attachments

(1 file)

GetURI() doesn't fail when it returns null. Better to null check.
Also we return E_FAIL when NS_SUCCEEDED!
Attachment #305490 - Flags: review?(marco.zehe)
Oops, should be:
  if (NS_FAILED(rv) || !uri)
Comment on attachment 305490 [details] [diff] [review]
Fix vodka-inspired code and whisky-inspired code review

R=me
Attachment #305490 - Flags: review?(marco.zehe)
Attachment #305490 - Flags: review+
Attachment #305490 - Flags: approval1.9?
Comment on attachment 305490 [details] [diff] [review]
Fix vodka-inspired code and whisky-inspired code review

a1.9+=damons
Attachment #305490 - Flags: approval1.9? → approval1.9+
Status: NEW → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
Summary: Crash [ @ CAccessibleHyperlink::get_anchorTarget() ] → Crash [@ CAccessibleHyperlink::get_anchorTarget() ]
Crash Signature: [@ CAccessibleHyperlink::get_anchorTarget() ]
You need to log in before you can comment on or make changes to this bug.