Closed Bug 419413 Opened 15 years ago Closed 15 years ago

Crash [@ CAccessibleHyperlink::get_anchorTarget() ]

Categories

(Core :: Disability Access APIs, defect)

Product:
Core
Component:
Disability Access APIs
Type:
defect
Priority:
Not set
Severity:
critical

Tracking

()

Status:
RESOLVED FIXED

People

(Reporter: aaronlev, Assigned: aaronlev)

Details

(Keywords: access, crash)

Crash Data

Attachments

(1 file)

Fix vodka-inspired code and whisky-inspired code review
1001 bytes, patch
MarcoZ
: review+
damons
: approval1.9+
Details | Diff | Splinter Review 
GetURI() doesn't fail when it returns null. Better to null check.
Also we return E_FAIL when NS_SUCCEEDED!

        Attachment #305490 -
        Flags: review?(marco.zehe)

    
    

    
  
Oops, should be:
  if (NS_FAILED(rv) || !uri)


    
    

    
  
Comment on attachment 305490 [details] [diff] [review]
Fix vodka-inspired code and whisky-inspired code review

R=me

        Attachment #305490 -
        Flags: review?(marco.zehe)

        Attachment #305490 -
        Flags: review+

        Attachment #305490 -
        Flags: approval1.9?

    
    

    
  
Comment on attachment 305490 [details] [diff] [review]
Fix vodka-inspired code and whisky-inspired code review

a1.9+=damons

        Attachment #305490 -
        Flags: approval1.9? → approval1.9+

    
  
Status: NEW → RESOLVED
Closed: 15 years ago
Resolution: --- → FIXED

    
  
Summary: Crash [ @  CAccessibleHyperlink::get_anchorTarget() ] → Crash [@ CAccessibleHyperlink::get_anchorTarget() ]
Crash Signature: [@ CAccessibleHyperlink::get_anchorTarget() ]

          You need to log in
          before you can comment on or make changes to this bug.