Closed
Bug 419413
Opened 16 years ago
Closed 16 years ago
Crash [@ CAccessibleHyperlink::get_anchorTarget() ]
Categories
(Core :: Disability Access APIs, defect)
Core
Disability Access APIs
Tracking
()
RESOLVED
FIXED
People
(Reporter: aaronlev, Assigned: aaronlev)
Details
(Keywords: access, crash)
Crash Data
Attachments
(1 file)
|
1001 bytes,
patch
|
MarcoZ
:
review+
damons
:
approval1.9+
|
Details | Diff | Splinter Review |
GetURI() doesn't fail when it returns null. Better to null check.
|
Assignee | |
Comment 1•16 years ago
|
||
Also we return E_FAIL when NS_SUCCEEDED!
|
|
Assignee | |
Comment 2•16 years ago
|
||
Attachment #305490 -
Flags: review?(marco.zehe)
|
|
Assignee | |
Comment 3•16 years ago
|
||
Oops, should be: if (NS_FAILED(rv) || !uri)
|
||
Comment 4•16 years ago
|
||
Comment on attachment 305490 [details] [diff] [review] Fix vodka-inspired code and whisky-inspired code review R=me
Attachment #305490 -
Flags: review?(marco.zehe)
Attachment #305490 -
Flags: review+
Attachment #305490 -
Flags: approval1.9?
|
||
Comment 5•16 years ago
|
||
Comment on attachment 305490 [details] [diff] [review] Fix vodka-inspired code and whisky-inspired code review a1.9+=damons
Attachment #305490 -
Flags: approval1.9? → approval1.9+
|
|
Assignee | |
Updated•16 years ago
|
Status: NEW → RESOLVED
Closed: 16 years ago
Resolution: --- → FIXED
Summary: Crash [ @ CAccessibleHyperlink::get_anchorTarget() ] → Crash [@ CAccessibleHyperlink::get_anchorTarget() ]
|
||
Updated•13 years ago
|
Crash Signature: [@ CAccessibleHyperlink::get_anchorTarget() ]
You need to log in
before you can comment on or make changes to this bug.
Description
•