Improve pkits shell script.

RESOLVED FIXED in 3.12

Status

NSS
Test
RESOLVED FIXED
10 years ago
10 years ago

People

(Reporter: Slavomir Katuscak, Assigned: Slavomir Katuscak)

Tracking

Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 1 obsolete attachment)

78.15 KB, patch
Julien Pierre
: review+
Details | Diff | Splinter Review
(Assignee)

Description

10 years ago
Some things to improve:
-fix bugs in tests
-add new tests (4.4.19-4.4.21)
-comment failing tests (when bug is in NSS code, feature is not supported,...)
-add cert DB restore instead of deleting certs and CRLs
(Assignee)

Updated

10 years ago
Depends on: 232894, 415767
(Assignee)

Comment 1

10 years ago
Created attachment 305507 [details] [diff] [review]
Patch v1.

Added all mentioned in bug description + variable $NSS_NO_PKITS_POLICIES changed to $NSS_PKITS_POLICIES (we don't support this feauture by default and it caused many test failures). 

To-do:
-this patch contains also patch from bug 415767, so it's dependency which should be fixed first.
-we need to have copy of PKITS_DATA, so there is dependency on bug 232894 (at least on patch planned to add there)
-missing 4.14 and 4.15 parts of PKITS suite (seems that NSS doesn't support this yet)
(Assignee)

Comment 2

10 years ago
Changing dependency on bug 232894. Pkits.sh can run also with manually copied PKITS_DATA, but 232894 can't be automated without working pkits.sh.
Blocks: 232894
No longer depends on: 232894
Summary: Improve pkist.sh script. → Improve pkits shell script.
(Assignee)

Comment 3

10 years ago
Created attachment 306485 [details] [diff] [review]
Patch v2.

The same as patch v1 but after patch from bug 415767 is checked in.
Attachment #305507 - Attachment is obsolete: true
Attachment #306485 - Flags: review?(julien.pierre.boogz)

Updated

10 years ago
Attachment #306485 - Flags: review?(julien.pierre.boogz) → review+
(Assignee)

Comment 4

10 years ago
Checking in pkits.sh;
/cvsroot/mozilla/security/nss/tests/pkits/pkits.sh,v  <--  pkits.sh
new revision: 1.20; previous revision: 1.19
done
(Assignee)

Updated

10 years ago
Status: NEW → RESOLVED
Last Resolved: 10 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.