Closed
Bug 41943
Opened 24 years ago
Closed 24 years ago
don't call PerformExpand() on startup for imap servers
Categories
(SeaMonkey :: MailNews: Message Display, defect, P3)
Tracking
(Not tracked)
VERIFIED
FIXED
M17
People
(Reporter: sspitzer, Assigned: sspitzer)
Details
(Whiteboard: fix in hand)
we call perform expand on any servers that are expanded (open) in the folder pane on start up of messenger. see PerformExpandForAllOpenServers() in msgMail3PaneWindow.js I added that originally so that we'd update the unread counts for news. we recently implemented PerformExpand() for imap servers. we talked it over and we are not going to do this for imap. I've got the fix for this. I'll check in today.
Assignee | ||
Comment 1•24 years ago
|
||
accepting.
Assignee | ||
Comment 2•24 years ago
|
||
I'm going to check in once the tree opens. I think there might be other bugs out there that will go away once I fix this. if you know of any, please mark them as duplicates.
Assignee | ||
Comment 3•24 years ago
|
||
fix checked in.
Assignee | ||
Comment 4•24 years ago
|
||
marking fixed.
Status: ASSIGNED → RESOLVED
Closed: 24 years ago
Resolution: --- → FIXED
Assignee | ||
Comment 5•24 years ago
|
||
I think the reason we turned this off for imap was to avoid making multiple connections to the imap server. david, do you remember if there was another reason? I can't remember
Comment 6•24 years ago
|
||
I think that was probably it - if we're going to select the inbox anyway, it's going to do folder discovery, and that will probably still be going on when we open the inbox, so two connections will get used. It's probably OK to do PerformExpand on the non-default servers, i.e., the ones that aren't going to have the inbox opened (unless it causes a password prompt, which we don't want - perhaps another reason not to do this)
QA Contact: lchiang → stephend
Verified FIXED: We've added a check in http://lxr.mozilla.org/seamonkey/source/mailnews/base/resources/content/msgMail3PaneWindow.js#613 611 var server = msgFolder.server; 612 // Don't do this for imap servers. See bug #41943 613 if (server.type != "imap") 614 server.performExpand(msgWindow); after getting (server), we check the (type) property and if it's not IMAP, then we call performExpand() and pass in the msgWindow object. I know everybody cc:ed on this bug knows that, but hey, I'm learning JS...
Status: RESOLVED → VERIFIED
Updated•20 years ago
|
Product: Browser → Seamonkey
You need to log in
before you can comment on or make changes to this bug.
Description
•