Missing context menu icons

RESOLVED FIXED in Firefox 3

Status

()

RESOLVED FIXED
11 years ago
11 years ago

People

(Reporter: micmon, Assigned: ispence)

Tracking

Trunk
Firefox 3
x86
Linux
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Reporter)

Description

11 years ago
Follow-up to 405165, a few more places where context menu icons are missing:

- Places organizer sidebar: "open all in tabs" and "open all in windows" (new tab/new window icons)

- bookmarks toolbar bookmarks: "open in a new tab" and "open in a new window" as well as  Properties (gtk-properties)

- bookmarks toolbar containters (folders and livemark folders): "open all in tabs" and "open all in windows" as well as  Properties (gtk-properties). Additionally for live mark containers: "Reload live bookmark" (gtk-reload)

Comment 1

11 years ago
Please see bug 417476 (This Frame context submenu) and bug 415664 (source viewer).

Comment 2

11 years ago
Also add meta (General) and resources (Media) lists context menus icons in Page Info.

They lack Select All, and Copy icons.
Ian, want to pick these last ones up? We're very close to having menu icons everywhere! :)
(Assignee)

Comment 4

11 years ago
Shall try to have it done later this morning
(Assignee)

Comment 5

11 years ago
Created attachment 310955 [details] [diff] [review]
Adds more icons to context menus

Adds the icons requested

Also, I know I probably shouldn't do this, but I noticed that the Home icon in the history menu is broken, so I fixed that as well
Assignee: nobody → ispence
Status: NEW → ASSIGNED
Attachment #310955 - Flags: review?(mano)
Comment on attachment 310955 [details] [diff] [review]
Adds more icons to context menus

r=mano
Attachment #310955 - Flags: review?(mano) → review+
Comment on attachment 310955 [details] [diff] [review]
Adds more icons to context menus

Theme patch for gnomestripe that will hopefully take care of the last of the missing menu icons.
Attachment #310955 - Flags: approval1.9b5?
Attachment #310955 - Flags: approval1.9?
Comment on attachment 310955 [details] [diff] [review]
Adds more icons to context menus

doesn't need to land for b5, can land after
Attachment #310955 - Flags: approval1.9b5?
Attachment #310955 - Flags: approval1.9b5-
Attachment #310955 - Flags: approval1.9?
Attachment #310955 - Flags: approval1.9+
Keywords: checkin-needed
Checking in browser/base/content/browser-menubar.inc;
/cvsroot/mozilla/browser/base/content/browser-menubar.inc,v  <--  browser-menubar.inc
new revision: 1.156; previous revision: 1.155
done
Checking in browser/base/content/pageinfo/pageInfo.xul;
/cvsroot/mozilla/browser/base/content/pageinfo/pageInfo.xul,v  <--  pageInfo.xul
new revision: 1.17; previous revision: 1.16
done
Checking in browser/themes/gnomestripe/browser/browser.css;
/cvsroot/mozilla/browser/themes/gnomestripe/browser/browser.css,v  <--  browser.css
new revision: 1.203; previous revision: 1.202
done
Checking in browser/themes/gnomestripe/browser/pageInfo.css;
/cvsroot/mozilla/browser/themes/gnomestripe/browser/pageInfo.css,v  <--  pageInfo.css
new revision: 1.17; previous revision: 1.16
done
Checking in browser/themes/gnomestripe/browser/places/places.css;
/cvsroot/mozilla/browser/themes/gnomestripe/browser/places/places.css,v  <--  places.css
new revision: 1.29; previous revision: 1.28
done
Status: ASSIGNED → RESOLVED
Last Resolved: 11 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 3

Updated

11 years ago
Depends on: 425625
You need to log in before you can comment on or make changes to this bug.