Follow-up to 405165, a few more places where context menu icons are missing: - Places organizer sidebar: "open all in tabs" and "open all in windows" (new tab/new window icons) - bookmarks toolbar bookmarks: "open in a new tab" and "open in a new window" as well as Properties (gtk-properties) - bookmarks toolbar containters (folders and livemark folders): "open all in tabs" and "open all in windows" as well as Properties (gtk-properties). Additionally for live mark containers: "Reload live bookmark" (gtk-reload)
Also add meta (General) and resources (Media) lists context menus icons in Page Info. They lack Select All, and Copy icons.
Ian, want to pick these last ones up? We're very close to having menu icons everywhere! :)
Shall try to have it done later this morning
Created attachment 310955 [details] [diff] [review] Adds more icons to context menus Adds the icons requested Also, I know I probably shouldn't do this, but I noticed that the Home icon in the history menu is broken, so I fixed that as well
Assignee: nobody → ispence
Status: NEW → ASSIGNED
Attachment #310955 - Flags: review?(mano)
Comment on attachment 310955 [details] [diff] [review] Adds more icons to context menus r=mano
Attachment #310955 - Flags: review?(mano) → review+
Comment on attachment 310955 [details] [diff] [review] Adds more icons to context menus Theme patch for gnomestripe that will hopefully take care of the last of the missing menu icons.
Comment on attachment 310955 [details] [diff] [review] Adds more icons to context menus doesn't need to land for b5, can land after
Checking in browser/base/content/browser-menubar.inc; /cvsroot/mozilla/browser/base/content/browser-menubar.inc,v <-- browser-menubar.inc new revision: 1.156; previous revision: 1.155 done Checking in browser/base/content/pageinfo/pageInfo.xul; /cvsroot/mozilla/browser/base/content/pageinfo/pageInfo.xul,v <-- pageInfo.xul new revision: 1.17; previous revision: 1.16 done Checking in browser/themes/gnomestripe/browser/browser.css; /cvsroot/mozilla/browser/themes/gnomestripe/browser/browser.css,v <-- browser.css new revision: 1.203; previous revision: 1.202 done Checking in browser/themes/gnomestripe/browser/pageInfo.css; /cvsroot/mozilla/browser/themes/gnomestripe/browser/pageInfo.css,v <-- pageInfo.css new revision: 1.17; previous revision: 1.16 done Checking in browser/themes/gnomestripe/browser/places/places.css; /cvsroot/mozilla/browser/themes/gnomestripe/browser/places/places.css,v <-- places.css new revision: 1.29; previous revision: 1.28 done
Status: ASSIGNED → RESOLVED
Last Resolved: 11 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 3
You need to log in before you can comment on or make changes to this bug.