419555 - "Edit Draft" does not open a compose window

Status: RESOLVED FIXED

(Thunderbird :: General, defect)

Description

[Joe Sabash [:JoeS1]]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8.0.6) Gecko/20060804 Firefox/1.5.0.6 (mahowi)
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9b4pre) Gecko/2008021803 Thunderbird/3.0a1pre ID:2008021803

Double-clicking on a draft fails to open the draft in compose mode.
Also seen with Templates.

Reproducible: Always

Steps to Reproduce:
1.Double click an existed draft
2.
3.
Actual Results:  
Does not open in composition

Comment 1

[Joe Sabash [:JoeS1]]

Fails Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9b4pre) Gecko/2008021903 Thunderbird/3.0a1pre ID:2008021903

OK   Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9b4pre) Gecko/2008021803 Thunderbird/3.0a1pre ID:2008021803

Suspect bug 416666 since the last 3 numbers have a bad conotation,
and also because -var msgComposeType; is part of the checkin.
Error console:
Error: msgComposeType is not defined
Source File: chrome://messenger/content/threadPane.js
Line: 175

Comment 2

[Joey Minta]

Attachment: patch

I don't have a good setup to test this, but this should do the trick.  If someone can confirm that it fixes things, I'll request review.  Otherwise it may take a few days for me to get my ducks in a row.

Comment 3

[Phil Ringnalda (:philor)]

Nope, needs something for msgComposeFormat too. I'm on the fence about whether using consts adds any clarity over just wrapping the arguments over a few lines, and using Components.interfaces.foo.bar directly.

Comment 4

[Thomas Schade]

This effects also the handling of templates. Also here double-klicking on a template doesn't open it for editing.

Comment 5

[Joey Minta]

Attachment: patch v2

Simple bustage fix.  This time with msgComposeFormat also. :-)

Comment 6

[Joey Minta]

Checking in mailnews/base/resources/content/threadPane.js;
/cvsroot/mozilla/mailnews/base/resources/content/threadPane.js,v  <--  threadPane.js
new revision: 1.92; previous revision: 1.91
done