419578 - Add a "Recently Closed" history submenu

Status: RESOLVED FIXED

(Camino Graveyard :: History, enhancement)

Description

[Stuart Morgan]

As a preliminary form of tab undo, we can create a submenu under history of recently closed sites, similar to the FF2 UI. Just keeping the URL of recently closed tabs/windows (rather than actually having restorable state of the window) should be pretty easy, and would cover a lot of the cases that undo would be used for (the "oh crap, what was that tab I just accidentally closed?" case).

Comment 1

[Stuart Morgan]

Attachment: localizable string

I'm hoping to do this for 1.6; to keep that option open, we can land the string, and I can follow with the code after b3.

Comment 2

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

Comment on attachment 305684 [details] [diff] [review]
localizable string

Sam and I both prefer "Recently Closed Pages" here, since this folder won't be history items in the same "linear-by-visit/pageload" sense as the rest of that menu.  That extra built-in clarity also gives us a little flexibility in where we put the item in the menu, since we're getting the string in before the code.

This is another bug, but do we actually use the code that LocalFilesCategoryTitle belongs to?

Comment 3

[Stuart Morgan]

Attachment: string, take 2 [landed]

Fair enough.

(I wondered about LocalFilesCategoryTitle as well; I'd have to dig into it some to figure out when it would be used, if ever.)

Comment 4

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

Comment on attachment 305691 [details] [diff] [review]
string, take 2 [landed]

r=ardissone

Comment 5

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

Marcello, just FYI for l10n teams, this bug is another case (like some of the session-saving-related strings in 1.5) where we're going to land a string before the freeze and possibly add the actual implementation later.

Comment 6

[Mike Pinkerton (not reading bugmail)]

Comment on attachment 305691 [details] [diff] [review]
string, take 2 [landed]

sr=pink

Comment 7

[Stuart Morgan]

Comment on attachment 305691 [details] [diff] [review]
string, take 2 [landed]

String change landed on trunk and MOZILLA_1_8_BRANCH.

Comment 8

[Stuart Morgan]

Attachment: fix

Smokey, want to take this for a spin?

Comment 9

[Stuart Morgan]

Attachment: v2

We tried various locations after some IRC discussion; this puts it in its own separated-off section just above Clear History. While I'm not wild about the extra separators, this seemed like the best solution.

Comment 10

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

Comment on attachment 339702 [details] [diff] [review]
v2

This looks good and works (almost) as expected; r=ardissone if you exclude about:blank.

I'll file a follow-up on excluding "Move Tab to New Window" from the list until such time it's just a view move, since conceptually it's not a tab close to the users.

Comment 11

[Stuart Morgan]

Attachment: v3

Ignores blank pages, and all about: pages as well so we don't get things like bookmarks and history. (Yes, that means we ignore things like about:plugins, but since about: pages are more part of our UI than actual pages, and we ignore them in global history, that seems like the right behavior.)

Comment 12

[Mike Pinkerton (not reading bugmail)]

Comment on attachment 339714 [details] [diff] [review]
v3

sr=pink

Comment 13

[Stuart Morgan]

Landed on cvs trunk.