419615 - use JSVERSION_LATEST in xpcshell

Status: RESOLVED FIXED

(Core :: XPConnect, defect)

Description

[Mike Shaver (:shaver -- probably not reading bugmail closely)]

Bug 384370 comment 91 shows the woes inflicted by xpcshell not tracking the latest version of JS: can't write the same code in unit tests as in the code itself, without ugly and future-hostile version() calls.

Patching and making check, will attach here presently.

Comment 2

[Reed Loden [:reed]]

Attachment: patch - v1

Something like this? I'll run make check on it in a bit.

Comment 3

[Brian Crowder]

Comment on attachment 305748 [details] [diff] [review]
patch - v1

Going to take a slightly different approach, patch in a second.

Comment 4

[Brian Crowder]

Attachment: use a context callback to set error-reporter and jsversion default

This matches what we do in the js-shell init.

From xpcshell:
js> let x = 5
js> x
5

Comment 5

[Mike Shaver (:shaver -- probably not reading bugmail closely)]

Comment on attachment 305834 [details] [diff] [review]
use a context callback to set error-reporter and jsversion default

r=shaver if this make-checks clean, thanks!

Comment 6

[Ed Lee :Mardak]

I suppose a followup bug could be filed to remove these lines:

http://mxr.mozilla.org/seamonkey/search?string=version(1&find=test_

Comment 7

[Ed Lee :Mardak]

Actually, I was pretty sure I was using let in other places without version..

http://mxr.mozilla.org/seamonkey/search?string=let&find=test_pluralForm_makeGetter.js

I think somewhere along the way the tests are being run with -v 170 ?

Comment 8

[Ed Lee :Mardak]

Sayrer added "... $xpcshell -v 180 ... " to tools/test-harness/xpcshell-simple/test_all.sh for bug 387522.

http://bonsai.mozilla.org/cvsblame.cgi?file=/mozilla/tools/test-harness/xpcshell-simple/test_all.sh&rev=1.13&mark=114#114

Would we need to remove that line and automatically use the latest version with the patch here?

Comment 9

[Brian Crowder]

Yeah, if a particular test wishes to remain on the latest version, then those version settings will need to be removed.  -v will override the setting I'm doing, as will version() in a script.

Comment 10

[Brian Crowder]

Comment on attachment 305834 [details] [diff] [review]
use a context callback to set error-reporter and jsversion default

I think that while this is not part of the browser-build, if it failed it would burn tboxes, so asking for approval.

Comment 11

[Mike Shaver (:shaver -- probably not reading bugmail closely)]

Comment on attachment 305834 [details] [diff] [review]
use a context callback to set error-reporter and jsversion default

Yep, thanks -- a=shaver.

Comment 12

[Reed Loden [:reed]]

Landed for rc1... I also removed the |-v 180|.

Checking in js/src/xpconnect/shell/xpcshell.cpp;
/cvsroot/mozilla/js/src/xpconnect/shell/xpcshell.cpp,v  <--  xpcshell.cpp
new revision: 1.109; previous revision: 1.108
done
Checking in tools/test-harness/xpcshell-simple/test_all.sh;
/cvsroot/mozilla/tools/test-harness/xpcshell-simple/test_all.sh,v  <--  test_all.sh
new revision: 1.14; previous revision: 1.13
done