419617 - Tags expander (progressive disclosure widget) should be native on GTK

Status: RESOLVED INACTIVE

(Firefox :: Bookmarks & History, defect)

Description

[u294409]

User-Agent:       Mozilla/5.0 (X11; U; Linux i686; pl; rv:1.9b4pre) Gecko/2008022604 Fedora/8 (Werewolf) Minefield/3.0b4pre
Build Identifier: Mozilla/5.0 (X11; U; Linux i686; pl; rv:1.9b4pre) Gecko/2008022604 Fedora/8 (Werewolf) Minefield/3.0b4pre

firefox now for "tags" used own expander - little button with non-native arrow.

gtk provides nice widget made especially for such tasks - special arrow with label and nice hover indicator.

Reproducible: Always

Steps to Reproduce:
1.
2.
3.
Actual Results:  
own expander

Expected Results:  
native gtk expander

Comment 1

[Reed Loden [:reed]]

Screenshot, please?

Comment 2

[Michael Monreal [:micmon]]

Attachment: Screenshot

Same thing can be seen in places organizer. The arrows are already used in the places treeview. Problem is that we don't get hover feedback, which makes the use of these arrows a bit strange in this place... otherwise they would be the right choice.

Comment 3

[u294409]

Actually I was talking 'bout Places, but it is the same problem (; .

Comment 4

[Marc Diethelm]

This is a duplicate of bug 404771.

Comment 5

[Julien "_FrnchFrgg_" RIVAUD]

(In reply to comment #4)
> This is a duplicate of bug 404771.

Not really. Tree expanders are looking native, the only problem is that they don't react to hover and don't animate. IIUC, here we probably have to use the same expanders even outside of the tree, which is IIRC easier said than done since tree expanders aren't a real widget, so there maybe isn't a matching -moz-appearance.

Comment 6

[Julien "_FrnchFrgg_" RIVAUD]

By "real widget" I meant "firefox frame". That is the tree calculates the position of the expanders and directly asks the native theme system to draw an expander at the right position.

Comment 8

[Julien "_FrnchFrgg_" RIVAUD]

Let's make this bug about all three places expanders, the two of the "star" popup, and the one of "Bookmarks Organizer".

Comment 10

[Julien "_FrnchFrgg_" RIVAUD]

The expanders should use "-moz-appearance: treetwisty(open)?" styles.

Comment 11

[Michael Ventnor]

treetwisty draws the expander at the treeview styles. I think I left code in gtk2drawing.c that draws the regular expander, but there is no appearance value mapped to that yet.

Comment 12

[Julien "_FrnchFrgg_" RIVAUD]

They can be different ? Crap.

Comment 13

[Gervase Markham [:gerv]]

Bug 451915 - move Firefox/Places bugs to Firefox/Bookmarks and History. Remove all bugspam from this move by filtering for the string "places-to-b-and-h".

In Thunderbird 3.0b, you do that as follows:
Tools | Message Filters
Make sure the correct account is selected. Click "New"
Conditions: Body   contains   places-to-b-and-h
Change the action to "Delete Message".
Select "Manually Run" from the dropdown at the top.
Click OK.

Select the filter in the list, make sure "Inbox" is selected at the bottom, and click "Run Now". This should delete all the bugspam. You can then delete the filter.

Gerv

Comment 14

[BMO Automation]

Per policy at https://wiki.mozilla.org/Bug_Triage/Projects/Bug_Handling/Bug_Husbandry#Inactive_Bugs. If this bug is not an enhancement request or a bug not present in a supported release of Firefox, then it may be reopened.