Closed Bug 419653 Opened 12 years ago Closed 12 years ago

use of max(a,b) is confusing windows mobile compiler.

Categories

(Core :: Layout, defect)

x86
macOS
defect
Not set

Tracking

()

RESOLVED FIXED

People

(Reporter: dougt, Assigned: dougt)

Details

Attachments

(1 file)

Attached patch patch v.1Splinter Review
in a few places in layout, we have code that looks like this:

nsSize max(NS_INTRINSICSIZE,NS_INTRINSICSIZE);

The problem is that there is a function |max| defined for Windows Mobile.  The workaround is to not use "max" as a variable name for nsSize types.

in the patch I also renamed |min| to |minsize| so that it would look consistent.
Attachment #305783 - Flags: review?(dbaron)
Comment on attachment 305783 [details] [diff] [review]
patch v.1

r=dbaron, although could you use "maxSize" and "minSize" to match local style better?
Attachment #305783 - Flags: review?(dbaron) → review+
Comment on attachment 305783 [details] [diff] [review]
patch v.1

sure. :-)
Attachment #305783 - Flags: approval1.9?
Comment on attachment 305783 [details] [diff] [review]
patch v.1

a=beltzner for 1.9
Attachment #305783 - Flags: approval1.9? → approval1.9+
Checking in generic/nsGfxScrollFrame.cpp;
/cvsroot/mozilla/layout/generic/nsGfxScrollFrame.cpp,v  <--  nsGfxScrollFrame.cpp
new revision: 3.335; previous revision: 3.334
done
Checking in xul/base/src/nsBox.cpp;
/cvsroot/mozilla/layout/xul/base/src/nsBox.cpp,v  <--  nsBox.cpp
new revision: 1.136; previous revision: 1.135
done
Checking in xul/base/src/nsSprocketLayout.cpp;
/cvsroot/mozilla/layout/xul/base/src/nsSprocketLayout.cpp,v  <--  nsSprocketLayout.cpp
new revision: 1.67; previous revision: 1.66
done
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Assignee: nobody → doug.turner
You need to log in before you can comment on or make changes to this bug.