419653 - use of max(a,b) is confusing windows mobile compiler.

Status: RESOLVED FIXED

(Core :: Layout, defect)

Description

[Doug Turner (:dougt)]

Attachment: patch v.1

in a few places in layout, we have code that looks like this:

nsSize max(NS_INTRINSICSIZE,NS_INTRINSICSIZE);

The problem is that there is a function |max| defined for Windows Mobile.  The workaround is to not use "max" as a variable name for nsSize types.

in the patch I also renamed |min| to |minsize| so that it would look consistent.

Comment 1

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Comment on attachment 305783 [details] [diff] [review]
patch v.1

r=dbaron, although could you use "maxSize" and "minSize" to match local style better?

Comment 2

[Doug Turner (:dougt)]

Comment on attachment 305783 [details] [diff] [review]
patch v.1

sure. :-)

Comment 3

[Mike Beltzner [:beltzner, not reading bugmail]]

Comment on attachment 305783 [details] [diff] [review]
patch v.1

a=beltzner for 1.9

Comment 4

[Doug Turner (:dougt)]

Checking in generic/nsGfxScrollFrame.cpp;
/cvsroot/mozilla/layout/generic/nsGfxScrollFrame.cpp,v  <--  nsGfxScrollFrame.cpp
new revision: 3.335; previous revision: 3.334
done
Checking in xul/base/src/nsBox.cpp;
/cvsroot/mozilla/layout/xul/base/src/nsBox.cpp,v  <--  nsBox.cpp
new revision: 1.136; previous revision: 1.135
done
Checking in xul/base/src/nsSprocketLayout.cpp;
/cvsroot/mozilla/layout/xul/base/src/nsSprocketLayout.cpp,v  <--  nsSprocketLayout.cpp
new revision: 1.67; previous revision: 1.66
done