Closed Bug 419662 Opened 13 years ago Closed 11 years ago

function statement and destructuring parameter name clash still favours the parameter

Categories

(Core :: JavaScript Engine, defect, P2)

defect

Tracking

()

VERIFIED FIXED

People

(Reporter: igor, Assigned: igor)

References

Details

(Keywords: verified1.9.1, Whiteboard: fixed-in-tracemonkey)

Attachments

(1 file, 2 obsolete files)

+++ This bug was initially created as a clone of Bug #410649 +++

See bug 410649 comment 21.
Blocks: 410649
No longer depends on: 410649
Duplicate of this bug: 416737
Another incarnation of this bug comes from bug 416737. See bug 416737 comment 6 for a test case and analysis.
Raising priority and nominating for 1.9.1 as the bug 416737, a dup of this one, is 1.9.1 P2 blocker.
Severity: minor → critical
Flags: blocking1.9.1?
Priority: -- → P2
Attached patch v1 (obsolete) — Splinter Review
The patch makes sure that the destructuring argument initializer comes as the first thing in function's bytecode.
Attachment #370180 - Flags: review?(brendan)
Attached patch v2 (obsolete) — Splinter Review
The new patch checks for destructuring arguments only if function contains functions definitions that require the emit order change.
Attachment #370180 - Attachment is obsolete: true
Attachment #370184 - Flags: review?(brendan)
Attachment #370180 - Flags: review?(brendan)
Flags: blocking1.9.1? → blocking1.9.1+
Attachment #370184 - Flags: review?(brendan) → review?(mrbkap)
Attachment #370184 - Flags: review?(mrbkap) → review+
Attached patch v3Splinter Review
The version of the patch adds missing change to the xdr version.
Attachment #370184 - Attachment is obsolete: true
Attachment #370811 - Flags: review+
Attachment #370811 - Attachment description: v2 → v3
landed to TM - http://hg.mozilla.org/tracemonkey/rev/f6407cd260ca
Whiteboard: fixed-in-tracemonkey
http://hg.mozilla.org/mozilla-central/rev/f6407cd260ca
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
covered by js1_7/regress/regress-410649.js and soon to be added js1_5/Regress/regress-416737-01.js, js1_5/Regress/regress-416737-02.js
Flags: in-testsuite+
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.