Closed Bug 419751 Opened 14 years ago Closed 14 years ago

implement an update command for resetting the database

Categories

(Toolkit :: Safe Browsing, defect, P1)

Product:
Toolkit
Component:
Safe Browsing
Type:
defect

Tracking

()

Status:
RESOLVED FIXED
Milestone:
Firefox 3 beta4

People

(Reporter: dcamp, Assigned: dcamp)

Details

Attachments

(2 files)

temporary fix
1.00 KB, patch
tony
: review+
beltzner
: approval1.9b4+
beltzner
: approval1.9+
Details | Diff | Splinter Review
protocol command implementation
4.86 KB, patch
tony
: review+
beltzner
: approval1.9b4+
Details | Diff | Splinter Review 
In the (hopefully) rare case that google needs to reset the chunk numbers for their database, they need a way to tell clients to start over from scratch.
Flags: blocking-firefox3?
OS: Mac OS X → All
Hardware: PC → All
Attached patch temporary fix — — Splinter Review 
I'm not going to be able to implement this in time for beta 4, and google's about to reset the database.

The attached patch will reset the database for nightly/beta4 users as a temporary solution until we can get a protocol-level solution.
Assignee: nobody → dcamp
Status: NEW → ASSIGNED
Attachment #305895 - Flags: review?(tony)
Attachment #305895 - Flags: review?(tony) → review+
Attachment #305895 - Flags: approval1.9?
Priority: -- → P2
Comment on attachment 305895 [details] [diff] [review]
temporary fix

a=beltzner for 1.9
Attachment #305895 - Flags: approval1.9? → approval1.9+
I'd ideally like to wait to land this until google resets, which should be sometime tonight.
Comment on attachment 305895 [details] [diff] [review]
temporary fix

OK, google has reset the db, we should land this before shipping b4.
Attachment #305895 - Flags: approval1.9b4?
Priority: P2 → P1
Target Milestone: --- → Firefox 3 beta4
Comment on attachment 305895 [details] [diff] [review]
temporary fix

a1.9b4=beltzner
Attachment #305895 - Flags: approval1.9b4? → approval1.9b4+
Landed the b4 patch.

Checking in nsUrlClassifierDBService.cpp;
/cvsroot/mozilla/toolkit/components/url-classifier/src/nsUrlClassifierDBService.cpp,v  <--  nsUrlClassifierDBService.cpp
new revision: 1.66; previous revision: 1.65
done

Fixed enough for beta 4, the actual command for resetting the database needs to be agreed on with our google friends.
Attachment #306581 - Flags: review?(tony)
Attachment #306581 - Flags: review?(tony) → review+
Comment on attachment 306581 [details] [diff] [review]
protocol command implementation

I wouldn't say this is necessary for b4, but it might be nice to get it in early.
Attachment #306581 - Flags: approval1.9b4?
Comment on attachment 306581 [details] [diff] [review]
protocol command implementation

a1.9b4=beltzner
Attachment #306581 - Flags: approval1.9b4? → approval1.9b4+
Checking in src/nsUrlClassifierDBService.cpp;
/cvsroot/mozilla/toolkit/components/url-classifier/src/nsUrlClassifierDBService.cpp,v  <--  nsUrlClassifierDBService.cpp
new revision: 1.67; previous revision: 1.66
done
Checking in tests/unit/test_streamupdater.js;
/cvsroot/mozilla/toolkit/components/url-classifier/tests/unit/test_streamupdater.js,v  <--  test_streamupdater.js
new revision: 1.6; previous revision: 1.5
done
Status: ASSIGNED → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
Product: Firefox → Toolkit
You need to log in before you can comment on or make changes to this bug.