Closed Bug 419760 Opened 13 years ago Closed 13 years ago

Update windows theme for 78 pixel wide keyhole

Categories

(Firefox :: Theme, defect, P1)

x86
Windows XP
defect

Tracking

()

RESOLVED FIXED
Firefox 3 beta4

People

(Reporter: faaborg, Assigned: mcdavis941.bugs)

References

Details

Attachments

(3 files, 3 obsolete files)

I'm currently in the process of compositing together a new toolbar.png.  We would like to have the etch extend to the left side, making the entire keyhole 76 pixels wide. This breaks down horizontally as:

[back 36 pixels][forward 28 pixels][drop down 12 pixels]

the height will remain the same.

I'll post the new toolbar.png once it is done, but I wanted to get the sizes up since we are nearing freeze.
sorry, made another change:

[back 38 pixels][forward 28 pixels][drop down 14 pixels]
Summary: Update windows theme for 76 pixel wide keyhole → Update windows theme for 78 pixel wide keyhole
Attached image Example of a 78 by 34 keyhole (obsolete) —
Attachment #305896 - Attachment is obsolete: true
Attached image Example toolbar.png (in progress) (obsolete) —
Flags: blocking-firefox3?
Hardware: All → PC
Attachment #305906 - Attachment is obsolete: true
Attachment #305920 - Attachment is obsolete: true
mcdavis, chances are that you can start morphing the CSS required for this before we have the final image, right?
Flags: blocking-firefox3? → blocking-firefox3+
Priority: -- → P1
Attached image Toolbar-aero.png
Here is the aero version
(In reply to comment #6)
> mcdavis, chances are that you can start morphing the CSS required for this
> before we have the final image, right?
> 
Right.  Alex asked if I could get this in this evening and got me started with dimensions earlier.  There's a work in progress patch coming shortly.
This will probably need some padding to keep it from actually touching the left edge of the window. See https://bugzilla.mozilla.org/show_bug.cgi?id=414842#c9
Not yet tested on RTL but expected to be good for both LTR and RTL versions.
Attachment #305959 - Attachment is patch: true
Ready for review.
Attachment #305959 - Flags: review?(gavin.sharp)
(In reply to comment #11)
> Ready for review.

Was unable to test for RTL -- I tried but a stock install of the 02-26 Hebrew nightly couldn't get past crash-on-launch, even without any changes by me -- so maybe someone else could look at this from an RTL perspective?  If no one does, I'll have another go at this tomorrow.

I'm asking for review anyway because I think Alex wants this in.

is there a bug tracking the crash? such things need to be investigated...
Target Milestone: --- → Firefox 3 beta4
(In reply to comment #13)
> is there a bug tracking the crash? such things need to be investigated...
> 
Filed Bug 419966

There's also Bug 415531, although it doesn't seem necessarily related.

Attachment #305959 - Flags: review?(gavin.sharp)
Attachment #305959 - Flags: review+
Attachment #305959 - Flags: approval1.9b4?
Assignee: nobody → mcdavis941.bugs
Depends on: 414389
Comment on attachment 305959 [details] [diff] [review]
browser.css changes v1

a1.9b4=beltzner

This needs to land with the ZIP file (coming soon!) with new icon files in bug 414389
Attachment #305959 - Flags: approval1.9b4? → approval1.9b4+
Checking in browser/themes/winstripe/browser/browser.css;
/cvsroot/mozilla/browser/themes/winstripe/browser/browser.css,v  <--  browser.css
new revision: 1.182; previous revision: 1.181
done
Status: NEW → RESOLVED
Closed: 13 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Something I recently found: (http://forums.mozillazine.org/viewtopic.php?p=3277517#3277517)

The back button looks like it's lower than it possibly wants to be. I'll try to map it out:


File Edit
--------
(space)
(back button)
--bottom of toolbar--


The top of the back button does not scrape against the top of the toolbar, while the bottom of the back button does scrape against the bottom of the toolbar.

Intended? It looks like some re-positioning of the back/forward button may need to happen if things are to look perfectly aligned.  Look here for more information:

Edit
-------
(some space)
-----keyhole
(space a)
(forward button)
(space a)
-----keyhole
bottom of toolbar

I -think- "space a" above and below the forward button are both the same, but if you look closely below the Edit option, it looks like the heyhole is positioned too far down.
Possible I spoke to soon with the above note:

I was directed towards bug 415329 - large toolbar buttons are vertically misaligned.
https://bugzilla.mozilla.org/show_bug.cgi?id=415329
You need to log in before you can comment on or make changes to this bug.