419768 - esc-env.ast should be read from a predictable place

Status: RESOLVED FIXED

(Tamarin Graveyard :: Self-hosting compiler (ESC), defect)

Description

[Mark Hammond [:markh] [:mhammond]]

esc's bootstrap code includes the line:

    var esc_env_str = readFile ("esc-env.ast");

This assumes that the current working directory is the directory containing that file, but this will rarely be case in embedding situations (eg, ScreamingMonkey).  A work-around is to chdir() before running script code, but this may break the host application (eg, IE may not appreciate havings its cwd changed)

I'm not sure what the best solution is (and I guess it depends if esc-env.ast or anything else will remain separate files over the long term).  I'm logging this bug primarily so the chdir() hack in ScreamingMonkey has a bug to point at.

Comment 1

[Lars T Hansen]

IMO esc-env.ast should probably be gotten rid of and instead constructed internally in esc-core.es, by building the correct data structures explicitly (either going via a hand-built Ast or not).

Comment 2

[Chris Peyer]

Fixed in 326337b86ed6, aab6928ac8e2, 97eef45f9672

esc-env.ast has been changed to /src/esc-env.es

boot code has been removed.