419779 - ExcludeItems is not ignored for history queries

Status: RESOLVED WONTFIX

(Firefox :: Bookmarks & History, defect)

Description

[cmtalbert]

Attachment: Testcase

As the attached test case demonstrates, the excludeItems query option is not being ignored for history queries. It is claimed in the interface specification that this should be ignored for non-bookmark queries:
http://mxr.mozilla.org/mozilla/source/toolkit/components/places/public/nsINavHistoryService.idl#992

If you comment out the excludeItems line, (line 75), the test will pass as expected.

Tested on current pull of trunk codebase: 02-26-08.

Comment 1

[Marco Bonardo [:mak]]

mh, and i hope it continue to be not ignored since we would need it if we go splitting history in the library...

Comment 2

[Dietrich Ayala (:dietrich)]

Attachment: fix + updated testcase

Comment 3

[Marco Bonardo [:mak]]

Attachment: screenshot with patch applied and splitted history

i still don't get why we should ignore excludeItems for history queries, when history will be splitted in the Library, we will show items in the left pane, and that is a perf killer and a bad behaviour. The screenshot shows what happens with this patch checked-in.

So i would rather update the documentation removing the fact that the options is ignored (excludeItems should generically indicate we only want folders/containers from a query).

Alternatively we could inherit the expandQueries option from the root, as already done for excludeItems, this way excludeItems is ignored but since internal queries inherit expandQueries they should not expand. So it would become:

  PRBool isHistoryQuery =
    mOptions->QueryType() == nsINavHistoryQueryOptions::QUERY_TYPE_HISTORY;

  // if we are child of an ExcludeItems root, we should not expand
  if (mResult && mResult->mRootNode->mOptions->ExcludeItems() &&
      !isHistoryQuery)
    return PR_FALSE;

  if (mResult && !mResult->mRootNode->mOptions->ExpandQueries())
    return PR_FALSE;

Comment 4

[Marco Bonardo [:mak]]

Comment on attachment 319934 [details] [diff] [review]
fix + updated testcase

removing review request for now (see comment above)

Comment 5

[Marco Bonardo [:mak]]

could we simply fix the idl comment since our history queries have become more complex. or alternatively ignore it only for non-queries containers (so not grouped results)

Comment 6

[Marco Bonardo [:mak]]

i'm going to change the comment in bug 422163, since i need it to apply to history queries.

Comment 7

[Marco Bonardo [:mak]]

wontfix per bug 422163. i fixed the comment in the idl to reflect this.

Comment 8

[Gervase Markham [:gerv]]

Bug 451915 - move Firefox/Places bugs to Firefox/Bookmarks and History. Remove all bugspam from this move by filtering for the string "places-to-b-and-h".

In Thunderbird 3.0b, you do that as follows:
Tools | Message Filters
Make sure the correct account is selected. Click "New"
Conditions: Body   contains   places-to-b-and-h
Change the action to "Delete Message".
Select "Manually Run" from the dropdown at the top.
Click OK.

Select the filter in the list, make sure "Inbox" is selected at the bottom, and click "Run Now". This should delete all the bugspam. You can then delete the filter.

Gerv