419840 - Options Panel - Advanced tab - no buttons work - XUL error

Status: VERIFIED FIXED

(Firefox :: Settings UI, defect, P1)

Description

[Jim Jeffery not reading bug-mail 1/2/11]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 6.0; en-US; rv:1.9b4pre) Gecko/2008022704 Minefield/3.0b4pre Firefox/3.0
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 6.0; en-US; rv:1.9b4pre) Gecko/2008022704 Minefield/3.0b4pre Firefox/3.0

Open Tools->Options Advanced:  none of the buttons under the tabs work. Clicking on them does nothing, creates the following error:

Error: gAdvancedPane is undefined
Source file: chrome://browser/content/preferences/preferences.xul
Line: 1


Reproducible: Always

Steps to Reproduce:
1.
2.
3.
Actual Results:  
Error msg in Console2
Error: gAdvancedPane is undefined
Source file: chrome://browser/content/preferences/preferences.xul
Line: 1


Expected Results:  
Buttons should work

Today's nightly - Vista HP
Mozilla/5.0 (Windows; U; Windows NT 6.0; en-US; rv:1.9b4pre) Gecko/2008022704 Minefield/3.0b4pre Firefox/3.0 ID:2008022704

Comment 1

[Jim Jeffery not reading bug-mail 1/2/11]

Pal-moz reports:
OK : 20080226_1255_firefox-3.0b4pre.en-US.win32.zip
NG : 20080226_1334_firefox-3.0b4pre.en-US.win32.zip 


maybe https://bugzilla.mozilla.org/show_bug.cgi?id=397417 cause this.

Comment 2

[Steve England [:stevee]]

Checkins to module PhoenixTinderbox between 2008-02-26 12:55 and 2008-02-26 13:33 : 
http://bonsai.mozilla.org/cvsquery.cgi?module=PhoenixTinderbox&date=explicit&mindate=1204059300&maxdate=1204061639

Comment 3

[Jim Jeffery not reading bug-mail 1/2/11]

Also seeing:
Error: Cu is not defined
Source file: chrome://browser/content/preferences/advanced.js
Line: 4

Comment 4

[Mike Beltzner [:beltzner, not reading bugmail]]

This blocks beta 4. Confirmed working on OSX, not working on Vista, and I'm not sure if the patch was tested on Windows or not.

Comment 5

[Jim Jeffery not reading bug-mail 1/2/11]

Yes, its also broken on XP 

Comment 6

[Dave Camp (:dcamp)]

Attachment: fix

grr, same stupid Cu-only-on-mac thing

Comment 7

[Mike Connor [:mconnor]]

Comment on attachment 306026 [details] [diff] [review]
fix

please land ASAP!

Comment 8

[:Gavin Sharp [email: [e-mail]]]

Landed this for Dave.
mozilla/browser/components/preferences/advanced.js 	1.34

Comment 9

[Jim Jeffery not reading bug-mail 1/2/11]

Fixed in this hourly:
Mozilla/5.0 (Windows; U; Windows NT 6.0; en-US; rv:1.9b4pre) Gecko/2008022710 Minefield/3.0b4pre Firefox/3.0 ID:2008022710

Comment 11

[Eric Fowler]

Just wanted to confirm that this fix did work on XP, I can test on vista if needed, but I assume this fix corrects the issue.

Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9b4pre) Gecko/2008022710 Minefield/3.0b4pre ID:2008022710