Closed Bug 420026 Opened 14 years ago Closed 14 years ago

get rid of folderDragOver.png (open folder with arrow) in winstripe and pinstripe

Categories

(Firefox :: Theme, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
Firefox 3 beta4

People

(Reporter: beltzner, Assigned: reed)

References

()

Details

Attachments

(1 file, 2 obsolete files)

This seems to be a holdover from the early days of Places. There's an ugly (see URL) icon that seems to mean "drop the thing in this folder". It's not really necessary (drag and drop works fine on its own, and dropmarkers show up inside the folders) and the state ends up sometimes sticking.

Anyway, it should be removed.

on winstripe it's referenced here:

http://mxr.mozilla.org/firefox/source/browser/themes/winstripe/browser/browser.css#1684

on pinstripe it's referenced here:

http://mxr.mozilla.org/firefox/source/browser/themes/pinstripe/browser/browser.css#1340
Flags: blocking-firefox3+
And for good measure we can take the file out of the manifests and not package it.
gnomestripe lost this in bug 410347.
OS: Windows Vista → All
Hardware: PC → All
Version: unspecified → Trunk
Attached patch patch - v1 (obsolete) — Splinter Review
Be gone!
Assignee: nobody → reed
Status: NEW → ASSIGNED
Attachment #306207 - Flags: review?(gavin.sharp)
Why are you removing the rest of the dragover styling?
Attached patch patch - v2 (obsolete) — Splinter Review
*sigh*

I removed |-moz-appearance: none|, too, as I think that was used for the image part, but I could be wrong there...
Attachment #306207 - Attachment is obsolete: true
Attachment #306208 - Flags: review?(gavin.sharp)
Attachment #306207 - Flags: review?(gavin.sharp)
Attached patch patch - v3Splinter Review
I'm worthless.
Attachment #306208 - Attachment is obsolete: true
Attachment #306210 - Flags: review?(gavin.sharp)
Attachment #306208 - Flags: review?(gavin.sharp)
Attachment #306210 - Flags: review?(gavin.sharp) → review?(mano)
Attachment #306210 - Flags: approval1.9b4?
Attachment #306210 - Flags: approval1.9?
Comment on attachment 306210 [details] [diff] [review]
patch - v3

a1.9b4=beltzner
Attachment #306210 - Flags: approval1.9b4?
Attachment #306210 - Flags: approval1.9b4+
Attachment #306210 - Flags: approval1.9?
Attachment #306210 - Flags: approval1.9+
Keywords: checkin-needed
Checking in browser/themes/pinstripe/browser/browser.css;
/cvsroot/mozilla/browser/themes/pinstripe/browser/browser.css,v  <--  browser.css
new revision: 1.130; previous revision: 1.129
done
Checking in browser/themes/pinstripe/browser/jar.mn;
/cvsroot/mozilla/browser/themes/pinstripe/browser/jar.mn,v  <--  jar.mn
new revision: 1.76; previous revision: 1.75
done
Removing browser/themes/pinstripe/browser/places/folderDragOver.png;
/cvsroot/mozilla/browser/themes/pinstripe/browser/places/folderDragOver.png,v  <--  folderDragOver.png
new revision: delete; previous revision: 1.1
done
Checking in browser/themes/winstripe/browser/browser.css;
/cvsroot/mozilla/browser/themes/winstripe/browser/browser.css,v  <--  browser.css
new revision: 1.180; previous revision: 1.179
done
Checking in browser/themes/winstripe/browser/jar.mn;
/cvsroot/mozilla/browser/themes/winstripe/browser/jar.mn,v  <--  jar.mn
new revision: 1.72; previous revision: 1.71
done
Removing browser/themes/winstripe/browser/places/folderDragOver.png;
/cvsroot/mozilla/browser/themes/winstripe/browser/places/folderDragOver.png,v  <--  folderDragOver.png
new revision: delete; previous revision: 1.1
done
Status: ASSIGNED → RESOLVED
Closed: 14 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 3 beta4
You need to log in before you can comment on or make changes to this bug.