Closed Bug 420067 Opened 14 years ago Closed 14 years ago

Extension list emblems

Categories

(Firefox :: Theme, defect)

x86
Linux
defect
Not set
normal

Tracking

()

RESOLVED FIXED
Firefox 3 beta5

People

(Reporter: micmon, Assigned: ispence)

Details

Attachments

(2 files)

The extension list currently uses icons from notifyBadges.png as emblems for the following cases:

- Extension is disabled because it is incompatible or causes other errors

- Update for the extension is available

Other states which had been used in FF3 have been disabled as far as I know, so we only need to provide tango versions of those two icons.
Actually now that we are going to use gtk-dialog-error also elsewhere in the UI, I think it would be great to use it here, also (for the first case).

Icon for case #2 will follow soon.
Attached image Update available icon
This uses the stock error icon for errors and that pretty orange star for updates.

This should be landed after bug 420569 since the line offsets in the diff are from after that patch is applied. (Shouldn't really matter, but just in case)

Also, when this lands, attachment 306264 [details] should be added as toolkit/themes/gnomestripe/mozapps/extensions/notifyBadges.png
Attachment #307034 - Flags: review?(mano)
Assignee: nobody → ispence
Comment on attachment 307034 [details] [diff] [review]
Uses pretty icons that make me do the tango

r=mano, pending ui-r.
Attachment #307034 - Flags: review?(mano) → review+
(In reply to comment #4)
> (From update of attachment 307034 [details] [diff] [review])
> r=mano, pending ui-r.

Why would this need ui-r? None of the other Linux native stuff has required ui-r. ... or do you just mean on the icon itself?
Comment on attachment 306264 [details]
Update available icon

faaborg, this icon ok?
Attachment #306264 - Flags: ui-review?(faaborg)
in case it helps, that update icon is the same icon that at least all Ubuntu users see in the taskbar when an update is available. So as soon as this pops in, a large base of users will immediately recognize it as the update icon
It's not the same but it was knowingly done very similar to the existing icon in gnome-icon-theme (which is what you see in ubuntu for example) for this specific reason.
Comment on attachment 306264 [details]
Update available icon

On other platforms we are planning on using a circle with an up arrow for this badge.  This will probably be green on XP and different shades of blue on Vista and OS X.  Ideally a 32x32 version of this badge would be used for the addons manager prefpane icon.
Attachment #306264 - Flags: ui-review?(faaborg) → ui-review+
>It's not the same but it was knowingly done very similar to the existing icon
>in gnome-icon-theme (which is what you see in ubuntu for example) for this
>specific reason.

Yeah, that is a great example of the type of visual integration with the platform that we are hoping to achieve with this release.
Attachment #307034 - Flags: approval1.9?
Comment on attachment 307034 [details] [diff] [review]
Uses pretty icons that make me do the tango

a1.9=beltzner
Attachment #307034 - Flags: approval1.9? → approval1.9+
Keywords: checkin-needed
Checking in toolkit/themes/gnomestripe/mozapps/jar.mn;
/cvsroot/mozilla/toolkit/themes/gnomestripe/mozapps/jar.mn,v  <--  jar.mn
new revision: 1.10; previous revision: 1.9
done
Checking in toolkit/themes/gnomestripe/mozapps/extensions/extensions.css;
/cvsroot/mozilla/toolkit/themes/gnomestripe/mozapps/extensions/extensions.css,v  <--  extensions.css
new revision: 1.17; previous revision: 1.16
done
RCS file: /cvsroot/mozilla/toolkit/themes/gnomestripe/mozapps/extensions/notifyBadges.png,v
done
Checking in toolkit/themes/gnomestripe/mozapps/extensions/notifyBadges.png;
/cvsroot/mozilla/toolkit/themes/gnomestripe/mozapps/extensions/notifyBadges.png,v  <--  notifyBadges.png
initial revision: 1.1
done
Status: NEW → RESOLVED
Closed: 14 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 3 beta5
You need to log in before you can comment on or make changes to this bug.