420067 - Extension list emblems

Status: RESOLVED FIXED

(Firefox :: Theme, defect)

Description

[Michael Monreal [:micmon]]

The extension list currently uses icons from notifyBadges.png as emblems for the following cases:

- Extension is disabled because it is incompatible or causes other errors

- Update for the extension is available

Other states which had been used in FF3 have been disabled as far as I know, so we only need to provide tango versions of those two icons.

Comment 1

[Michael Monreal [:micmon]]

Actually now that we are going to use gtk-dialog-error also elsewhere in the UI, I think it would be great to use it here, also (for the first case).

Icon for case #2 will follow soon.

Comment 2

[Michael Monreal [:micmon]]

Attachment: Update available icon

Comment 3

[Ian Spence]

Attachment: Uses pretty icons that make me do the tango

This uses the stock error icon for errors and that pretty orange star for updates.

This should be landed after bug 420569 since the line offsets in the diff are from after that patch is applied. (Shouldn't really matter, but just in case)

Also, when this lands, attachment 306264 [details] should be added as toolkit/themes/gnomestripe/mozapps/extensions/notifyBadges.png

Comment 4

[Asaf Romano (gone)]

Comment on attachment 307034 [details] [diff] [review]
Uses pretty icons that make me do the tango

r=mano, pending ui-r.

Comment 5

[Reed Loden [:reed]]

(In reply to comment #4)
> (From update of attachment 307034 [details] [diff] [review])
> r=mano, pending ui-r.

Why would this need ui-r? None of the other Linux native stuff has required ui-r. ... or do you just mean on the icon itself?

Comment 6

[Asaf Romano (gone)]

For the icon itself, right.

Comment 7

[Reed Loden [:reed]]

Comment on attachment 306264 [details]
Update available icon

faaborg, this icon ok?

Comment 8

[Ian Spence]

in case it helps, that update icon is the same icon that at least all Ubuntu users see in the taskbar when an update is available. So as soon as this pops in, a large base of users will immediately recognize it as the update icon

Comment 9

[Michael Monreal [:micmon]]

It's not the same but it was knowingly done very similar to the existing icon in gnome-icon-theme (which is what you see in ubuntu for example) for this specific reason.

Comment 10

[Alex Faaborg [:faaborg] (Firefox UX)]

Comment on attachment 306264 [details]
Update available icon

On other platforms we are planning on using a circle with an up arrow for this badge.  This will probably be green on XP and different shades of blue on Vista and OS X.  Ideally a 32x32 version of this badge would be used for the addons manager prefpane icon.

Comment 11

[Alex Faaborg [:faaborg] (Firefox UX)]

>It's not the same but it was knowingly done very similar to the existing icon
>in gnome-icon-theme (which is what you see in ubuntu for example) for this
>specific reason.

Yeah, that is a great example of the type of visual integration with the platform that we are hoping to achieve with this release.

Comment 12

[Mike Beltzner [:beltzner, not reading bugmail]]

Comment on attachment 307034 [details] [diff] [review]
Uses pretty icons that make me do the tango

a1.9=beltzner

Comment 13

[Reed Loden [:reed]]

Checking in toolkit/themes/gnomestripe/mozapps/jar.mn;
/cvsroot/mozilla/toolkit/themes/gnomestripe/mozapps/jar.mn,v  <--  jar.mn
new revision: 1.10; previous revision: 1.9
done
Checking in toolkit/themes/gnomestripe/mozapps/extensions/extensions.css;
/cvsroot/mozilla/toolkit/themes/gnomestripe/mozapps/extensions/extensions.css,v  <--  extensions.css
new revision: 1.17; previous revision: 1.16
done
RCS file: /cvsroot/mozilla/toolkit/themes/gnomestripe/mozapps/extensions/notifyBadges.png,v
done
Checking in toolkit/themes/gnomestripe/mozapps/extensions/notifyBadges.png;
/cvsroot/mozilla/toolkit/themes/gnomestripe/mozapps/extensions/notifyBadges.png,v  <--  notifyBadges.png
initial revision: 1.1
done