Print finer-grained leak info in runtests.py than just pass/fail and a table

RESOLVED FIXED in mozilla1.9

Status

Testing
Mochitest
--
enhancement
RESOLVED FIXED
11 years ago
10 years ago

People

(Reporter: Waldo, Assigned: Waldo)

Tracking

Trunk
mozilla1.9
Points:
---
Bug Flags:
in-testsuite -

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 1 obsolete attachment)

(Assignee)

Description

11 years ago
Created attachment 306344 [details] [diff] [review]
Patch

It'd be nice for the individual classes that leak to be printed as errors (and when the leak threshold isn't exceeded, to note the leaks in the log but not cause failure).

I tested this patch using bug 420152 with large and small leak thresholds sufficient to trigger both the error-fail and warning branches.
Attachment #306344 - Flags: review?(sayrer)
(Assignee)

Comment 1

11 years ago
Created attachment 306404 [details] [diff] [review]
Don't fail when refcount logging is disabled

I'm pretty sure leak logging will fail (catastrophically) in builds without refcount logging, because the leak file wouldn't be created.  This patch moves the file into the profile directory (to avoid staleness concerns) and prints a warning if the file isn't created when leak logging is enabled (which indicates that refcount logging is disabled).
Attachment #306344 - Attachment is obsolete: true
Attachment #306404 - Flags: review?(sayrer)
Attachment #306344 - Flags: review?(sayrer)

Updated

11 years ago
Attachment #306404 - Flags: review?(sayrer) → review+
(Assignee)

Comment 2

11 years ago
Fixt.
Status: ASSIGNED → RESOLVED
Last Resolved: 11 years ago
Flags: in-testsuite-
Resolution: --- → FIXED
Target Milestone: --- → mozilla1.9beta4
MochitestMassMove -- plz ignore.
Component: Testing → Mochitest
Product: Core → Testing
Target Milestone: mozilla1.9beta4 → mozilla1.9
QA Contact: testing → mochitest
You need to log in before you can comment on or make changes to this bug.