420180 - use the preprocessor on ImageUtils.jsm and install-shortcut.js

Status: VERIFIED FIXED

(Mozilla Labs :: Prism, defect)

Description

[Fredrik Larsson (:nossralf)]

Attachment: use preprocessor on ImageUtils.jsm

There are still a couple of places where it makes more sense to use the preprocessor, rather than run-time checks, to create platform-specific behavior. Namely:
ImageUtils.jsm
install-shortcut.js

I used separate patches for each file. Once again; I'm using hg locally, so use "patch -p1" to apply them.

Comment 1

[Fredrik Larsson (:nossralf)]

Attachment: use preprocessor on install-shortcut.js

Comment 2

[Fredrik Larsson (:nossralf)]

With these changes (and the ones that were landed in bug 419851), bug 418208 should be solved, since the order of #ifdefs use the Windows case as the catch-all default, so Mingw builds should use the correct Windows behavior.

Comment 3

[Mark Finkle (:mfinkle) (use needinfo?)]

landed

Comment 4

[Bo Yang]

Better solution than my patch, thank you!