If you think a bug might affect users in the 57 release, please set the correct tracking and status flags for Release Management.

use the preprocessor on ImageUtils.jsm and install-shortcut.js

VERIFIED FIXED

Status

Mozilla Labs
Prism
VERIFIED FIXED
10 years ago
10 years ago

People

(Reporter: nossralf, Assigned: nossralf)

Tracking

Details

Attachments

(2 attachments)

(Assignee)

Description

10 years ago
Created attachment 306381 [details] [diff] [review]
use preprocessor on ImageUtils.jsm

There are still a couple of places where it makes more sense to use the preprocessor, rather than run-time checks, to create platform-specific behavior. Namely:
ImageUtils.jsm
install-shortcut.js

I used separate patches for each file. Once again; I'm using hg locally, so use "patch -p1" to apply them.
(Assignee)

Comment 1

10 years ago
Created attachment 306382 [details] [diff] [review]
use preprocessor on install-shortcut.js
(Assignee)

Comment 2

10 years ago
With these changes (and the ones that were landed in bug 419851), bug 418208 should be solved, since the order of #ifdefs use the Windows case as the catch-all default, so Mingw builds should use the correct Windows behavior.
(Assignee)

Updated

10 years ago
Attachment #306381 - Flags: review?(mark.finkle)
Attachment #306381 - Flags: review?(mark.finkle) → review+
Attachment #306382 - Flags: review+
landed
Status: NEW → RESOLVED
Last Resolved: 10 years ago
Resolution: --- → FIXED
(Assignee)

Updated

10 years ago
Status: RESOLVED → VERIFIED

Comment 4

10 years ago
Better solution than my patch, thank you!
You need to log in before you can comment on or make changes to this bug.