420209 - Mac theme includes *-hover.png images no longer in use

Status: RESOLVED FIXED

(Firefox :: Theme, defect)

Description

[Myk Melez [:myk] [@mykmelez]]

The theme we ship for Mac OS X includes several images it no longer uses, specifically tab-left-hover.png, tab-middle-hover.png, and tab-right-hover.png.  These files should be CVS removed and references to them removed from <http://mxr.mozilla.org/mozilla/source/browser/themes/pinstripe/browser/jar.mn>.

Requesting wanted-firefox3 for this theme cleanup bug.

Comment 1

[Mike Beltzner [:beltzner, not reading bugmail]]

If you hunt these down and remove them, I'll buy the equivalent dollar-to-kb value of drinks for you.

Comment 2

[Myk Melez [:myk] [@mykmelez]]

Attachment: patch v1: removes files

Alcohol is a powerful motivator, leading me to check all files in tabbrowser/, whereupon I discovered another four that are no longer being used.  Here's the complete list of files in that directory that are no longer being used along with their sizes in bytes:

302 alltabs-box-overflow-bkgnd.png
654 tab-arrow-end-bkgnd-animate.png
693 tab-arrow-start-bkgnd-animate.png
342 tab-left-hover.png
185 tab-middle-hover.png
343 tab-right-hover.png
129 tabs-bottom-bg.png

Total: 2648 bytes, or about 2.6Kb, so I guess it's one cheap beer for me.

Comment 3

[Phil Ringnalda (:philor)]

Myk: you requested review from the wind, so nobody but the wind is going to be buying you a beer.

Comment 4

[Myk Melez [:myk] [@mykmelez]]

Comment on attachment 309057 [details] [diff] [review]
patch v1: removes files

Hrm, no wonder beltzner didn't immediately jump on this.

Comment 5

[Markus Stange [:mstange]]

Myk, I removed some of these images in bug 449832, I think. Could you update your patch and request review from mconnor? Thanks.

Comment 6

[Myk Melez [:myk] [@mykmelez]]

Attachment: patch v2: updated to tip

(In reply to comment #5)
> Myk, I removed some of these images in bug 449832, I think. Could you update
> your patch and request review from mconnor? Thanks.

It looks like you removed tab-(left|middle|right)-hover.png.  Here's a patch that removes the other five files no longer being used.

Comment 7

[Myk Melez [:myk] [@mykmelez]]

(In reply to comment #6)
> It looks like you removed tab-(left|middle|right)-hover.png.  Here's a patch
> that removes the other five files no longer being used.

Erm, I meant to say the other *four* files no longer being used.

Comment 8

[Mike Connor [:mconnor]]

Comment on attachment 339889 [details] [diff] [review]
patch v2: updated to tip

yay cleanup

Comment 9

[Myk Melez [:myk] [@mykmelez]]

Attachment: patch v3: resolves trivial conflict with nearby change

Here's a version of the patch that resolves a trivial conflict with a nearby but unrelated change.  This is the version of the patch I'll check in once the tree isn't burning.

Comment 10

[Myk Melez [:myk] [@mykmelez]]

Attachment: patch v4: more conflict resolution after updating my tree again

Comment 11

[Myk Melez [:myk] [@mykmelez]]

changeset:   20531:18e5c891c6bf
tag:         tip
date:        Wed Oct 15 22:58:30 2008 -0700
summary:     Bug 420209 - Mac theme includes images no longer in use; r=mconnor