InterlockedCompareExchange needs to be extern "C" when using a C++ compiler

RESOLVED FIXED

Status

()

Core
JavaScript Engine
RESOLVED FIXED
10 years ago
10 years ago

People

(Reporter: Benjamin Smedberg, Assigned: Benjamin Smedberg)

Tracking

unspecified
x86
Windows XP
Points:
---
Bug Flags:
in-testsuite -
in-litmus -

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

10 years ago
Created attachment 306414 [details] [diff] [review]
Use JS_BEGIN_EXTERN_C around the decl, rev. 1

Causing red on the windows mozilla-central tinderbox... change is trivial.
Attachment #306414 - Flags: review?(brendan)
Comment on attachment 306414 [details] [diff] [review]
Use JS_BEGIN_EXTERN_C around the decl, rev. 1

C++ compilation is good.

/be
Attachment #306414 - Flags: review?(brendan)
Attachment #306414 - Flags: review+
Attachment #306414 - Flags: approval1.9b4?
Attachment #306414 - Flags: approval1.9+
Comment on attachment 306414 [details] [diff] [review]
Use JS_BEGIN_EXTERN_C around the decl, rev. 1

a1.9b4=beltzner
Attachment #306414 - Flags: approval1.9b4? → approval1.9b4+
Summary: InterlockedComparreExchange needs to be exterrn "C" when using a C++ compiler → InterlockedCompareExchange needs to be extern "C" when using a C++ compiler
(Assignee)

Comment 3

10 years ago
I landed this on trunk last week.
Status: NEW → RESOLVED
Last Resolved: 10 years ago
Resolution: --- → FIXED

Updated

10 years ago
Flags: in-testsuite-
Flags: in-litmus-
You need to log in before you can comment on or make changes to this bug.