Closed Bug 420257 Opened 16 years ago Closed 11 years ago

virtual folder crash after change search criteria [@ nsCOMPtr_base::~nsCOMPtr_base() | nsMsgSearchOfflineMail::OpenSummaryFile()], [@ @0x746e6574 - @ nsMsgSearchOfflineMail::OpenSummaryFile()]

Categories

(MailNews Core :: Filters, defect)

x86
Windows XP
defect
Not set
critical

Tracking

(Not tracked)

RESOLVED WORKSFORME

People

(Reporter: wsmwk, Unassigned)

References

(Depends on 1 open bug)

Details

(Keywords: crash)

Crash Data

1. changed one term of virtual folder in local from body= to subject=
2. clicked inbox, 
3. clicked virtual folder

crash. bp-7c4f5819-e69d-11dc-9854-001a4bd43ed6
0  	@0x746e6574  	
1 	nsMsgSearchOfflineMail::OpenSummaryFile() 	mozilla/mailnews/base/search/src/nsMsgLocalSearch.cpp:322
2 	nsMsgSearchOfflineMail::Search(int*) 	mozilla/mailnews/base/search/src/nsMsgLocalSearch.cpp:652
3 	nsMsgSearchScopeTerm::TimeSlice(int*) 	mozilla/mailnews/base/search/src/nsMsgSearchTerm.cpp:1566
4 	nsMsgSearchSession::TimeSliceSerial(int*) 	mozilla/mailnews/base/search/src/nsMsgSearchSession.cpp:702
5 	nsMsgSearchSession::StartTimer() 	mozilla/mailnews/base/search/src/nsMsgSearchSession.cpp:554
6 	nsMsgSearchSession::BeginSearching() 	mozilla/mailnews/base/search/src/nsMsgSearchSession.cpp:447
7 	nsMsgSearchSession::Search(nsIMsgWindow*) 	mozilla/mailnews/base/search/src/nsMsgSearchSession.cpp:274
8 	NS_InvokeByIndex_P 	mozilla/xpcom/reflect/xptcall/src/md/win32/xptcinvoke.cpp:101
9 	XPCWrappedNative::CallMethod(XPCCallContext&, XPCWrappedNative::CallMode) 	mozilla/js/src/xpconnect/src/xpcwrappednative.cpp:2339
10 	XPC_WN_CallMethod(JSContext*, JSObject*, unsigned int, long*, long*) 	mozilla/js/src/xpconnect/src/xpcwrappednativejsops.cpp:1470


didn't attempt to reproduce same steps, but did have a different crash with different steps
bp-e718785e-e69e-11dc-b943-001a4bd43ed6
0  	nsMsgDBView::FnSortIdKeyPtr(void const*, void const*, void*)  	 mozilla/mailnews/base/src/nsMsgDBView.cpp:3296
1 	nsMsgDBView::GetInsertIndexHelper(nsIMsgDBHdr*, nsMsgKeyArray&, int, int) 	mozilla/mailnews/base/src/nsMsgDBView.cpp:4667
2 	nsMsgDBView::GetInsertIndex(nsIMsgDBHdr*) 	mozilla/mailnews/base/src/nsMsgDBView.cpp:4699
3 	nsMsgXFVirtualFolderDBView::InsertHdrFromFolder(nsIMsgDBHdr*, nsISupports*) 	mozilla/mailnews/base/src/nsMsgXFVirtualFolderDBView.cpp:155


from the top couple frames of the above stacks, 
nsMsgSearchOfflineMail::Search
and 
nsMsgDBView::GetInsertIndexHelper 
appear on talkback as top of stack near bottom of the top 500 crashers
(I didn't attempt to find the stacks on talkback)
Product: Core → MailNews Core
rkent, are these crashes still useful?

(I haven't seen this since, and can't currently reproduce. But of course doesn't mean the bug is gone.)
I guess old crash reports could be useful if there is some sort of possible fix for it, even a stupid fix (checking for null without understanding the underlying cause). But looking at the underlying code for this:

            nsCOMPtr<nsIMsgLocalMailFolder> localFolder = do_QueryInterface(scopeFolder, &err);
            if (NS_SUCCEEDED(err) && localFolder)
            {
              nsCOMPtr<nsIMsgSearchSession> searchSession;
              m_scope->GetSearchSession(getter_AddRefs(searchSession));
              if (searchSession)
              {
                nsCOMPtr <nsIMsgWindow> searchWindow;

                searchSession->GetWindow(getter_AddRefs(searchWindow));
                searchSession->PauseSearch();
                localFolder->ParseFolder(searchWindow, this);

(with the crash on the last line) it appears that the obvious checks are already being done, so that means there must be some side effects of the intervening calls - which are really tricky to trace out. So I would have no idea how to make progress with this. So I don't really see any value to this report anymore.
bp-a7b97d98-5300-49f5-baf0-952a22110207 might be the same stack. (not my crash, just pulled it off of crash-stats)

nsCOMPtr_base::~nsCOMPtr_base() | nsMsgSearchOfflineMail::OpenSummaryFile()
EXCEPTION_ACCESS_VIOLATION_READ
0xffffffffd6080191
0	xpcom_core.dll	nsCOMPtr_base::~nsCOMPtr_base	objdir-tb/mozilla/xpcom/build/nsCOMPtr.cpp:81
1	thunderbird.exe	nsMsgSearchOfflineMail::OpenSummaryFile	mailnews/base/search/src/nsMsgLocalSearch.cpp:334
2	thunderbird.exe	nsMsgSearchOfflineMail::Search	mailnews/base/search/src/nsMsgLocalSearch.cpp:736
3	thunderbird.exe	nsMsgSearchScopeTerm::TimeSlice	mailnews/base/search/src/nsMsgSearchTerm.cpp:1915
4	thunderbird.exe	nsMsgSearchSession::TimeSliceSerial	mailnews/base/search/src/nsMsgSearchSession.cpp:716
5	thunderbird.exe	nsMsgSearchSession::TimerCallback	mailnews/base/search/src/nsMsgSearchSession.cpp:544
6	thunderbird.exe	nsMsgSearchSession::StartTimer	mailnews/base/search/src/nsMsgSearchSession.cpp:568
7	thunderbird.exe	nsMsgSearchSession::BeginSearching	mailnews/base/search/src/nsMsgSearchSession.cpp:461
8	thunderbird.exe	nsMsgSearchSession::Search	mailnews/base/search/src/nsMsgSearchSession.cpp:289
9	thunderbird.exe	nsMsgPurgeService::SearchFolderToPurge	mailnews/base/src/nsMsgPurgeService.cpp:458
10	thunderbird.exe	nsMsgPurgeService::PerformPurge	mailnews/base/src/nsMsgPurgeService.cpp:386
Summary: virtual folder crash after change search criteria [@ @0x746e6574 - @ nsMsgSearchOfflineMail::OpenSummaryFile()] → virtual folder crash after change search criteria [@ sCOMPtr_base::~nsCOMPtr_base() | nsMsgSearchOfflineMail::OpenSummaryFile()], [@ @0x746e6574 - @ nsMsgSearchOfflineMail::OpenSummaryFile()]
Crash Signature: [@ sCOMPtr_base::~nsCOMPtr_base() | nsMsgSearchOfflineMail::OpenSummaryFile()] [@ @0x746e6574 - @ nsMsgSearchOfflineMail::OpenSummaryFile()]
filed Bug 698093 for crash nsMsgDBView::FnSortIdKeyPtr mentioned in comment 0
Crash Signature: [@ sCOMPtr_base::~nsCOMPtr_base() | nsMsgSearchOfflineMail::OpenSummaryFile()] [@ @0x746e6574 - @ nsMsgSearchOfflineMail::OpenSummaryFile()] → [@ nsCOMPtr_base::~nsCOMPtr_base() | nsMsgSearchOfflineMail::OpenSummaryFile()] [@ @0x746e6574 - @ nsMsgSearchOfflineMail::OpenSummaryFile()]
Depends on: 698093
See Also: → 465940
Summary: virtual folder crash after change search criteria [@ sCOMPtr_base::~nsCOMPtr_base() | nsMsgSearchOfflineMail::OpenSummaryFile()], [@ @0x746e6574 - @ nsMsgSearchOfflineMail::OpenSummaryFile()] → virtual folder crash after change search criteria [@ nsCOMPtr_base::~nsCOMPtr_base() | nsMsgSearchOfflineMail::OpenSummaryFile()], [@ @0x746e6574 - @ nsMsgSearchOfflineMail::OpenSummaryFile()]
no crashes since version 10 in February, a year ago, and even then extremely rare.
nsMsgSearchOfflineMail::OpenSummaryFile()
bp07a42ca92-1e5f-423d-bfdb-feb482120222

tempted to speculate fixed by bug 682731, but that landed in version 9
Status: NEW → RESOLVED
Crash Signature: [@ nsCOMPtr_base::~nsCOMPtr_base() | nsMsgSearchOfflineMail::OpenSummaryFile()] [@ @0x746e6574 - @ nsMsgSearchOfflineMail::OpenSummaryFile()] → [@ nsCOMPtr_base::~nsCOMPtr_base() | nsMsgSearchOfflineMail::OpenSummaryFile()] [@ @0x746e6574 - @ nsMsgSearchOfflineMail::OpenSummaryFile()] [@ nsMsgSearchOfflineMail::OpenSummaryFile()]
Closed: 11 years ago
Resolution: --- → WORKSFORME
You need to log in before you can comment on or make changes to this bug.