420383 - please QA the About landing page on the new Mozilla.com

Status: VERIFIED FIXED

(www.mozilla.org :: General, defect)

Description

[John Slater]

Hi Stephen. Please QA this page as discussed.

Thanks,
John

Comment 1

[Stephen Donner [:stephend] Not actively reading bugmail]

1) 6 XHTML 1.0 Strict validation errors (template-derived, likely)

2) The link for "The Mozilla Store" is http://store.mozilla.com, but production links to http://store.mozilla.org; I assume the latter is preferred, even though the former redirects?

3) The link to "Partnerships" (https://www-firefox3.stage.mozilla.com/en-US/about/Partnerships.html) is a 404; the global header nav link--which also 404s, is https://www-firefox3.stage.mozilla.com/en-US/about/partnerships/.  I found https://www-firefox3.stage.mozilla.com/en-US/about/partnerships.html, which works; is that the intended URL?

Comment 2

[John Slater]

2. yes, please link to store.mozilla.org
3. yep, that last one is the intended URL

Thanks,
J

Comment 3

[Steven Garrity [:sgarrity]]

Store and Partnerships links are fixed. Thanks.

The validation errors were indeed in the template and are now also fixed (this should help across all pages).

Should I be marking these bugs as fixed when I address the listed issues, or will that be up to you Stephen?

Comment 4

[Stephen Donner [:stephend] Not actively reading bugmail]

(In reply to comment #3)
> Store and Partnerships links are fixed. Thanks.
> 
> The validation errors were indeed in the template and are now also fixed (this
> should help across all pages).
> 
> Should I be marking these bugs as fixed when I address the listed issues, or
> will that be up to you Stephen?

Steven, sorry for the late response.  If we do at least the following:

A) Fix validation errors
B) Replace FPO images with final ones (or have spin-off bugs to do so),

then I'm ready to sign-off on this bug.

In general, and especially for the more-involved (download/JavaScript-heavy) pages, I think I want to do at least two rounds, and perhaps three, depending on whether template and CSS changes are still going on; what I don't want to do is have to keep reopening the same bug for these rounds.

When you also fix bugs, could you list SVN revision numbers?  I'm able to read diffs somewhat capably, and it would help when I want to point out regressions, etc.  So, if you can just say "fixed all current issues up to comment 2 in SVN 3065", for example, I can verify batch-by-batch, with me at some point asking you to mark fixed, with me subsequently verifying; that works best for me; you?

Comment 5

[Reed Loden [:reed]]

(In reply to comment #4)
> When you also fix bugs, could you list SVN revision numbers?  I'm able to read
> diffs somewhat capably, and it would help when I want to point out regressions,
> etc.  So, if you can just say "fixed all current issues up to comment 2 in SVN
> 3065", for example, I can verify batch-by-batch, with me at some point asking
> you to mark fixed, with me subsequently verifying; that works best for me; you?

Please use r<revision number> for Bugzilla to auto-link directly to ViewVC. Example: r10875. :)

Comment 6

[Stephen Donner [:stephend] Not actively reading bugmail]

4) https://www-firefox3.stage.mozilla.com/en-US/about/Licensing.html is a 404, and should be https://www-firefox3.stage.mozilla.com/en-US/about/licensing, instead

Comment 7

[Stephen Donner [:stephend] Not actively reading bugmail]

(In reply to comment #6)
> 4) https://www-firefox3.stage.mozilla.com/en-US/about/Licensing.html is a 404,
> and should be https://www-firefox3.stage.mozilla.com/en-US/about/licensing,
> instead

My bad; Reed just alerted me to MultiViews, so the correct URL for the Licensing link should be https://www-firefox3.stage.mozilla.com/en-US/about/licensing.html

Comment 8

[Steven Garrity [:sgarrity]]

Reed: I've been leaving the ".html" off to keep the URLs cleaner. Is this a bad idea?

Comment 9

[Marco Zehe (:MarcoZ)]

Except for the iframe I mention in bug 420389, which is present on all pages and sub pages of the "About Mozilla" category, this looks great! That includes the imagge library, too.

Comment 10

[Reed Loden [:reed]]

(In reply to comment #8)
> Reed: I've been leaving the ".html" off to keep the URLs cleaner. Is this a bad
> idea?

For things that are just an index.html file in a directory (such as /en-US/firefox/), just using the directory name is fine, but if the page is actually a <something>.html file (such as /en-US/about/licensing.html), I would prefer that you specify the ".html" suffix. I really don't trust MultiViews to always work correctly, and we've had problems in the past when we needed to redirect something that MultiViews made that very hard. So, if you would, please include the ".html" suffix for things that are not "index.html". :)

Comment 11

[Stephen Donner [:stephend] Not actively reading bugmail]

Verified FIXED:

* links are relative (where possible)
* MultiViews-proof using .html (again, where possible)
* page validates
* we'll get to the FPO artwork when we receive the final images, and in a separate bug