420389 - please QA the "Many Faces" page on the new Mozilla.com

Status: VERIFIED FIXED

(www.mozilla.org :: General, defect)

Description

[John Slater]

Hi Stephen. Please QA as discussed.

Thanks,
John

Comment 1

[Stephen Donner [:stephend] Not actively reading bugmail]

1) I saved the page locally, then uploaded to the W3C's validator; it fails to validate as XHTML 1.0 Strict (6 errors; production validates).
2) "Mozilla" in "The Many Faces of Mozilla" is hard-returned/line-broken, when there is still plenty of room for it to appear inline/flush with the rest of the header text; intentional?  Is it because it's missing a graphic?  If so, could you put an FPO image there so I don't forget to test it later? :-)

I tested the links and they all work.

Marco: any accessibility issues?  I double-checked that all images have ALT attributes.

Comment 2

[Marco Zehe (:MarcoZ)]

(In reply to comment #1)
> Marco: any accessibility issues?  I double-checked that all images have ALT
> attributes.

One thing: Please give the iframe element at the top a title attribute what this iframe is about. Right now, the URL of the JavaScript event handler is given as the frame's name/title, which is not good.

Comment 3

[Steven Garrity [:sgarrity]]

Marco, there was an iframe earlier, but I thought I had eliminated it. Can you confirm that it is still there?

Stephen, I've fixed the header wrapping issue in r10884.

Comment 4

[Marco Zehe (:MarcoZ)]

(In reply to comment #3)
> Marco, there was an iframe earlier, but I thought I had eliminated it. Can you
> confirm that it is still there?

Definitely still there. The "title" says something like "text/html;charset=utf-8,%3Chtml%3E%3Chead%3E%3Cscript%20type%3D%22text%2Fjavascript%22%3Ewindow.onresize%3Dfunction()%7Bwindow.parent.YAHOO.widget.Module.textResizeEvent".

Comment 5

[Steven Garrity [:sgarrity]]

Marco - right you are.

That iframe is created as a shim to detect browser font size changes by the YUI javascript library. Can you suggest how it should be titled? Then we can offer a patch to the YUI project.

Comment 6

[Marco Zehe (:MarcoZ)]

(In reply to comment #5)
> That iframe is created as a shim to detect browser font size changes by the YUI
> javascript library. Can you suggest how it should be titled? Then we can offer
> a patch to the YUI project.

Some useful plain text title like "font size detector" or something that summarizes what this iframe is for.

Comment 7

[Steven Garrity [:sgarrity]]

The iframe now has a title (we've patched our local copy of YUI and have a patch submitted upstream). Fixed in r11059.

Stephen - is that it for this page?

Comment 8

[Stephen Donner [:stephend] Not actively reading bugmail]

(In reply to comment #7)
> The iframe now has a title (we've patched our local copy of YUI and have a
> patch submitted upstream). Fixed in r11059.
> 
> Stephen - is that it for this page?

Ship it! :-P

Yeah, mark it fixed, and I'll...you know the drill. 

Comment 9

[Stephen Donner [:stephend] Not actively reading bugmail]

Verified; Marco, if you have any outstanding issues with this, please reopen or refile.