Closed Bug 420409 Opened 13 years ago Closed 13 years ago

Need to be able to print backtraces

Categories

(Core :: JavaScript Engine, defect)

x86
macOS
defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla1.9beta4

People

(Reporter: taras.mozilla, Assigned: taras.mozilla)

Details

(Keywords: regression)

Attachments

(1 file, 1 obsolete file)

The patch in bug 350650 caused the exception to be cleared before js_ReportErrorAgain calls the user-defined error handler.

Is there an alternative way of getting an error backtrace?
Comment on attachment 306647 [details] [diff] [review]
Keep exn object around for the callback

This seems fine to me, only a couple of nits.

>Index: jsexn.c
>         /* Flag the error as an exception. */
>         reportp->flags |= JSREPORT_EXCEPTION;
>+        /* Pass the exception object */

Add a blank line between the line and the error. Also, end the sentence with a period.
Blake, can you pick nits, get approval, and land? Need to fix this regression for 1.9/fx3.

/be
Assignee: general → mrbkap
Flags: blocking1.9+
Keywords: regression
I don't know which release this should track, trying b4 first, though I don't think it would be too terrible for this to go in after the freeze.
Attachment #306647 - Attachment is obsolete: true
Attachment #306786 - Flags: review+
Attachment #306786 - Flags: approval1.9b4?
Comment on attachment 306786 [details] [diff] [review]
Updated to my nits

a=mconnor on behalf of drivers
Attachment #306786 - Flags: approval1.9b4? → approval1.9b4+
Assignee: mrbkap → tglek
Fix checked in. Thanks for the patch, Taras!
Status: NEW → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla1.9beta4
Flags: in-testsuite-
Flags: in-litmus-
You need to log in before you can comment on or make changes to this bug.