420409 - Need to be able to print backtraces

Status: RESOLVED FIXED

(Core :: JavaScript Engine, defect)

Description

[(dormant account)]

The patch in bug 350650 caused the exception to be cleared before js_ReportErrorAgain calls the user-defined error handler.

Is there an alternative way of getting an error backtrace?

Comment 1

[(dormant account)]

Attachment: Keep exn object around for the callback

Comment 2

[Blake Kaplan (:mrbkap) (inactive)]

Comment on attachment 306647 [details] [diff] [review]
Keep exn object around for the callback

This seems fine to me, only a couple of nits.

>Index: jsexn.c
>         /* Flag the error as an exception. */
>         reportp->flags |= JSREPORT_EXCEPTION;
>+        /* Pass the exception object */

Add a blank line between the line and the error. Also, end the sentence with a period.

Comment 3

[Brendan Eich [:brendan]]

Blake, can you pick nits, get approval, and land? Need to fix this regression for 1.9/fx3.

/be

Comment 4

[Blake Kaplan (:mrbkap) (inactive)]

Attachment: Updated to my nits

I don't know which release this should track, trying b4 first, though I don't think it would be too terrible for this to go in after the freeze.

Comment 5

[Mike Connor [:mconnor]]

Comment on attachment 306786 [details] [diff] [review]
Updated to my nits

a=mconnor on behalf of drivers

Comment 6

[Blake Kaplan (:mrbkap) (inactive)]

Fix checked in. Thanks for the patch, Taras!